You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2014/10/10 11:19:54 UTC

Review Request 26544: FALCON-762

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/
-----------------------------------------------------------

Review request for Falcon and Ajay Yadava.


Repository: falcon-git


Description
-------

Support for listing feed instances for FileSystemStorage


Diffs
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
  client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
  client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
  client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
  client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
  client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
  common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
  common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 2689cb7 
  common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
  common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
  common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
  common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
  common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 4bb7772 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java fcd7b29 
  prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 5e351f6 
  prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
  prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 

Diff: https://reviews.apache.org/r/26544/diff/


Testing
-------


Thanks,

Ajay Yadava

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56670
-----------------------------------------------------------

Ship it!


- Ajay Yadava


On Oct. 15, 2014, 5:54 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 5:54 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 7e46f28 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
>   docs/src/site/twiki/FalconCLI.twiki 1d536a1 
>   docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 5:54 a.m.)


Review request for Falcon and Ajay Yadava.


Repository: falcon-git


Description
-------

Support for listing feed instances for FileSystemStorage


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
  client/src/main/java/org/apache/falcon/client/FalconClient.java 7e46f28 
  client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
  client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
  client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
  client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
  common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
  common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
  common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
  common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
  common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
  common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
  common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
  docs/src/site/twiki/FalconCLI.twiki 1d536a1 
  docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
  prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
  prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
  prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
  webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
  webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 

Diff: https://reviews.apache.org/r/26544/diff/


Testing
-------


Thanks,

Ajay Yadava

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56560
-----------------------------------------------------------



webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java
<https://reviews.apache.org/r/26544/#comment96907>

    One more minor nit, actual expression should be first argument and expected should be second argument. It's currently wrong in entire file but may be we can start with this test to correct it.


- Ajay Yadava


On Oct. 13, 2014, 10:53 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 10:53 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
>   docs/src/site/twiki/FalconCLI.twiki 1d536a1 
>   docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.

> On Oct. 14, 2014, 4:57 p.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 222
> > <https://reviews.apache.org/r/26544/diff/2/?file=719388#file719388line222>
> >
> >     Should here be a -name option to specify instances of which feed?
> 
> Srikanth Sundarrajan wrote:
>     Yes. Good catch. Will provide an update patch. Are there any other gaps ?

I didn't find any other gaps. Will apply patch and run tests once and will let you know.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56544
-----------------------------------------------------------


On Oct. 13, 2014, 10:53 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 10:53 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
>   docs/src/site/twiki/FalconCLI.twiki 1d536a1 
>   docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 26544: FALCON-762

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.

> On Oct. 14, 2014, 4:57 p.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 222
> > <https://reviews.apache.org/r/26544/diff/2/?file=719388#file719388line222>
> >
> >     Should here be a -name option to specify instances of which feed?

Yes. Good catch. Will provide an update patch. Are there any other gaps ?


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56544
-----------------------------------------------------------


On Oct. 13, 2014, 10:53 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 10:53 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
>   docs/src/site/twiki/FalconCLI.twiki 1d536a1 
>   docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56544
-----------------------------------------------------------



docs/src/site/twiki/FalconCLI.twiki
<https://reviews.apache.org/r/26544/#comment96899>

    Should here be a -name option to specify instances of which feed?


- Ajay Yadava


On Oct. 13, 2014, 10:53 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 10:53 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
>   docs/src/site/twiki/FalconCLI.twiki 1d536a1 
>   docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/
-----------------------------------------------------------

(Updated Oct. 13, 2014, 10:53 a.m.)


Review request for Falcon and Ajay Yadava.


Repository: falcon-git


Description
-------

Support for listing feed instances for FileSystemStorage


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
  client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
  client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
  client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
  client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
  client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
  common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
  common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6945cea 
  common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
  common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
  common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
  common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
  common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java b97564d 
  docs/src/site/twiki/FalconCLI.twiki 1d536a1 
  docs/src/site/twiki/restapi/FeedInstanceListing.twiki PRE-CREATION 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 41cd601 
  prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 2070713 
  prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
  prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
  webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 7a7d993 
  webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0943103 

Diff: https://reviews.apache.org/r/26544/diff/


Testing
-------


Thanks,

Ajay Yadava

Re: Review Request 26544: FALCON-762

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.

> On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 1051
> > <https://reviews.apache.org/r/26544/diff/1/?file=717378#file717378line1051>
> >
> >     Should it be a \n instead of \t?

Thanks for the catch


> On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 335
> > <https://reviews.apache.org/r/26544/diff/1/?file=717385#file717385line335>
> >
> >     Even though it's private, it will be very helpful to document with an example input and output.

Sure. taken care of.


> On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java, line 42
> > <https://reviews.apache.org/r/26544/diff/1/?file=717386#file717386line42>
> >
> >     Did you mean?
> >     Partial if partition is setup, but availability flag is missing.

Actually meant "Availability flag is configured in feed definition, but availability flag is missing in data path". correcting it.


> On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java, line 295
> > <https://reviews.apache.org/r/26544/diff/1/?file=717387#file717387line295>
> >
> >     Pagination will be helpful IMHO, though it shouldn't be a blocker for this feature.

instance limits are being applied on all instance apis. This will inherit it automatically when that is taken care of.


> On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java, line 296
> > <https://reviews.apache.org/r/26544/diff/1/?file=717387#file717387line296>
> >
> >     How about making start and end optional? In that case we can return latest 10 results.

This again is being handled generically across all instance api calls.


> On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java, line 319
> > <https://reviews.apache.org/r/26544/diff/1/?file=717387#file717387line319>
> >
> >     How about storing feed availability and feed path in Graph DB? That way it will be very easy for others to query last 10 instances etc. Won't it?

On Completion of workflow this is being saved, but we will also need information on instances which haven't yet completed successfully


On Oct. 10, 2014, 10:12 a.m., Ajay Yadava wrote:
> > Can we add documentation for the Client and the REST API? On a slightly side note: we currently don't document error responses in REST API, it will be very helpful if we do that.

Absolutely.


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56112
-----------------------------------------------------------


On Oct. 10, 2014, 9:19 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 9:19 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 2689cb7 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 4bb7772 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java fcd7b29 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 5e351f6 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 26544: FALCON-762

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26544/#review56112
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/26544/#comment96448>

    Should it be a \n instead of \t?



common/src/main/java/org/apache/falcon/entity/FeedHelper.java
<https://reviews.apache.org/r/26544/#comment96449>

    Even though it's private, it will be very helpful to document with an example input and output.



common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java
<https://reviews.apache.org/r/26544/#comment96450>

    Did you mean?
    Partial if partition is setup, but availability flag is missing.



common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java
<https://reviews.apache.org/r/26544/#comment96451>

    Pagination will be helpful IMHO, though it shouldn't be a blocker for this feature.



common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java
<https://reviews.apache.org/r/26544/#comment96452>

    How about making start and end optional? In that case we can return latest 10 results.



common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java
<https://reviews.apache.org/r/26544/#comment96453>

    How about storing feed availability and feed path in Graph DB? That way it will be very easy for others to query last 10 instances etc. Won't it?


Can we add documentation for the Client and the REST API? On a slightly side note: we currently don't document error responses in REST API, it will be very helpful if we do that.

- Ajay Yadava


On Oct. 10, 2014, 9:19 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26544/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 9:19 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Support for listing feed instances for FileSystemStorage
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java f7229ec 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java d73560d 
>   client/src/main/java/org/apache/falcon/resource/APIResult.java 79b8a1d 
>   client/src/main/java/org/apache/falcon/resource/FeedInstanceResult.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java 5754f97 
>   client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java 0758c8b 
>   common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 2689cb7 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4174135 
>   common/src/main/java/org/apache/falcon/entity/FeedInstanceStatus.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 58506ad 
>   common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
>   common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java 79d6e2d 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 4bb7772 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java fd8c63f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java fcd7b29 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 5e351f6 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java d172c3e 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java fbccd6b 
> 
> Diff: https://reviews.apache.org/r/26544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>