[jira] Commented: (TAPESTRY-1071) Client-side number validation does not work

["Marcus Schulte (JIRA)" <ta...@jakarta.apache.org>]

    [ http://issues.apache.org/jira/browse/TAPESTRY-1071?page=comments#action_12429213 ] 
            
Marcus Schulte commented on TAPESTRY-1071:
------------------------------------------

Should  be a simple fix in NumberTranslator:

The defaultFormat is "#", which is good.
Then, in renderContribution, the grouping separator is *always* passed to dojo in the JSON object (line 134).

I think, passing the grouping separator only if format.isGroupingUsed() returns true, should resolve the issue

Thus, instead of

   + "separator:" + JSONObject.quote(format.getDecimalFormatSymbols().getGroupingSeparator())

line 134 should probably read
 
 + ( format.isGroupingUsed ? "separator:" + JSONObject.quote(format.getDecimalFormatSymbols().getGroupingSeparator()) : "")

So, it's a trivial buggy after all. 

> Client-side number validation does not work
> -------------------------------------------
>
>                 Key: TAPESTRY-1071
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-1071
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 4.1.1
>         Environment: any, german locale (not sure whether this matters), Snapshot from Aug 15th
>            Reporter: Marcus Schulte
>         Assigned To: Jesse Kuhnert
>
> Specifiying no special pattern for the NumberTranslator leads to:
>  - client calls dojo number validation with groupingChar='  and any number of decimal places
>  - if you make dojo happy (eg. 1'234.0), validation fails on the server-side.
> If the reason for this is not a trivial omission which is easily fixed, I could investigate further ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org