You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/28 11:23:11 UTC
[GitHub] [incubator-eventmesh] jonyangx opened a new pull request, #2294: [ISSUE #2293] fix knative pmd test error
jonyangx opened a new pull request, #2294:
URL: https://github.com/apache/incubator-eventmesh/pull/2294
Fixes #2293 .
### Motivation
fix eventmesh-connector-plugin for knative pmd test error
### Modifications
fix eventmesh-connector-plugin for knative pmd test error
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2294: [ISSUE #2293] fix knative pmd test error
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2294:
URL: https://github.com/apache/incubator-eventmesh/pull/2294#issuecomment-1328949241
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2294](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20f538f) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/7599168e0564d02d9987ed9679863aebe3b71bf5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7599168) will **increase** coverage by `0.00%`.
> The diff coverage is `57.14%`.
```diff
@@ Coverage Diff @@
## master #2294 +/- ##
=========================================
Coverage 11.74% 11.75%
- Complexity 897 900 +3
=========================================
Files 468 469 +1
Lines 27849 27852 +3
Branches 3010 3010
=========================================
+ Hits 3272 3274 +2
- Misses 24278 24279 +1
Partials 299 299
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ve/cloudevent/impl/KnativeBinaryMessageReader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY2xvdWRldmVudC9pbXBsL0tuYXRpdmVCaW5hcnlNZXNzYWdlUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...connector/knative/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uZmlnL0NvbmZpZ3VyYXRpb25XcmFwcGVyLmphdmE=) | `52.63% <0.00%> (ø)` | |
| [...mesh/connector/knative/domain/NonStandardKeys.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvZG9tYWluL05vblN0YW5kYXJkS2V5cy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tmesh/connector/knative/producer/ProducerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvcHJvZHVjZXIvUHJvZHVjZXJJbXBsLmphdmE=) | `51.21% <0.00%> (+1.21%)` | :arrow_up: |
| [...sh/connector/knative/consumer/DefaultConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvRGVmYXVsdENvbnN1bWVyLmphdmE=) | `58.82% <33.33%> (-3.68%)` | :arrow_down: |
| [...h/connector/knative/consumer/PullConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvUHVsbENvbnN1bWVySW1wbC5qYXZh) | `32.25% <40.00%> (+1.11%)` | :arrow_up: |
| [...onnector/knative/consumer/KnativeConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvS25hdGl2ZUNvbnN1bWVySW1wbC5qYXZh) | `40.00% <75.00%> (ø)` | |
| [...ctor/knative/cloudevent/KnativeMessageFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY2xvdWRldmVudC9LbmF0aXZlTWVzc2FnZUZhY3RvcnkuamF2YQ==) | `50.00% <100.00%> (ø)` | |
| [.../knative/cloudevent/impl/KnativeMessageWriter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY2xvdWRldmVudC9pbXBsL0tuYXRpdmVNZXNzYWdlV3JpdGVyLmphdmE=) | `61.11% <100.00%> (+2.28%)` | :arrow_up: |
| [.../connector/knative/config/ClientConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uZmlnL0NsaWVudENvbmZpZ3VyYXRpb24uamF2YQ==) | `91.66% <100.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2294/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] pchengma commented on pull request #2294: [ISSUE #2293] fix knative pmd test error
Posted by GitBox <gi...@apache.org>.
pchengma commented on PR #2294:
URL: https://github.com/apache/incubator-eventmesh/pull/2294#issuecomment-1330751134
@jonyangx Thanks for your helpful contribution! The serialization part of the Knative-Connector has not been fully tested yet. It is well welcomed for more people to add some tests to the Knative-Connector.
LGTM for this commit.
@xwm1992 Please merge this commit when you have time. Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed pull request #2294: [ISSUE #2293] fix knative pmd test error
Posted by GitBox <gi...@apache.org>.
jonyangx closed pull request #2294: [ISSUE #2293] fix knative pmd test error
URL: https://github.com/apache/incubator-eventmesh/pull/2294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #2294: [ISSUE #2293] fix knative pmd test error
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #2294:
URL: https://github.com/apache/incubator-eventmesh/pull/2294#issuecomment-1335004348
Theses commits are too much seems the branch is under the wrong status. @jonyangx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org