[GitHub] [kafka] mimaison commented on pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.

[GitBox <gi...@apache.org>]

mimaison commented on pull request #11472:
URL: https://github.com/apache/kafka/pull/11472#issuecomment-968910011


   Thanks @dongjinleekr for the cleanup. It looks like you missed some changes in `DumpLogSegments.scala`:
   ```
   [Error] /Users/mickael/github/kafka/core/src/main/scala/kafka/tools/DumpLogSegments.scala:62: too many arguments (found 7, expected 6) for method dumpLog: (file: java.io.File, printContents: Boolean, nonConsecutivePairsForLogFilesMap: scala.collection.mutable.Map[String,List[(Long, Long)]], isDeepIteration: Boolean, parser: kafka.tools.DumpLogSegments.MessageParser[_, _], skipRecordMetadata: Boolean): Unit
   [Error] /Users/mickael/github/kafka/core/src/main/scala/kafka/tools/DumpLogSegments.scala:66: too many arguments (found 5, expected 4) for method dumpTimeIndex: (file: java.io.File, indexSanityOnly: Boolean, verifyOnly: Boolean, timeIndexDumpErrors: kafka.tools.DumpLogSegments.TimeIndexDumpErrors): Unit
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org