[GitHub] [druid] cryptoe commented on a diff in pull request #14101: Remove maxResultsSize config property from S3OutputConfig

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on code in PR #14101:
URL: https://github.com/apache/druid/pull/14101#discussion_r1168230915


##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3OutputConfig.java:
##########
@@ -48,10 +48,7 @@
 
   @Nullable
   @JsonProperty
-  private HumanReadableBytes chunkSize;
-
-  @JsonProperty
-  private HumanReadableBytes maxResultsSize = new HumanReadableBytes("100MiB");
+  private HumanReadableBytes chunkSize = new HumanReadableBytes("100MiB");

Review Comment:
   Do we still need :
   ```
    public static final long S3_MULTIPART_UPLOAD_MIN_OBJECT_SIZE_BYTES = 5L * 1024*1024;
    public static final long S3_MULTIPART_UPLOAD_MAX_OBJECT_SIZE_BYTES = 5L * 1024 * 1024 * 1024 * 1024;
   ```



##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3OutputConfig.java:
##########
@@ -48,10 +48,7 @@
 
   @Nullable
   @JsonProperty
-  private HumanReadableBytes chunkSize;

Review Comment:
   Please update the documentation also.
   The release notes should mention that the defaults have changed and the value is removed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org