[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1534: Mark ARRAY_AGG(DISTINCT ...) not implemented

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1534:
URL: https://github.com/apache/arrow-datafusion/pull/1534#discussion_r782474086



##########
File path: datafusion/src/physical_plan/aggregates.rs
##########
@@ -187,11 +187,16 @@ pub fn create_aggregate_expr(
                 coerced_exprs_types[0].clone(),
             ))
         }
-        (AggregateFunction::ArrayAgg, _) => Arc::new(expressions::ArrayAgg::new(
+        (AggregateFunction::ArrayAgg, false) => Arc::new(expressions::ArrayAgg::new(
             coerced_phy_exprs[0].clone(),
             name,
             coerced_exprs_types[0].clone(),
         )),
+        (AggregateFunction::ArrayAgg, true) => {
+            return Err(DataFusionError::NotImplemented(
+                "ARRAY_AGG(DISTINCT) aggregations are not available".to_string(),

Review comment:
       ```suggestion
                   "ARRAY_AGG(DISTINCT) aggregations are not yet implemented".to_string(),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org