You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/25 20:08:24 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #5898: Fix camel case in some methods' names
GutoVeronezi opened a new pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898
### Description
Fix camel case in some methods' names.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1021593557
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022132927
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022115249
> Looks good and should be done. One caveat is that some bean handling third party libraries may have required these to be in a different case and the names where on purpose. I do not know of these cases to be so.
Hey @DaanHoogland, thanks. These beans don't seem to be the case you mentioned, as they only handle our own packages.
Note: In case the beans that address these cases don't have javadoc, I think we should put some javadoc in them, explaining why they are written in different ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1021919226
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1023142946
@rohityadavcloud, yes, they were tested. The behavior is kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi merged pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
GutoVeronezi merged pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1021593897
@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022856125
Lgtm but one caveat, the getters and setters Methods are dynamically used during runtime to get the Field, were the affected APIs manually tested @GutoVeronezi? (such changes are not caught by smoketests that don't check api response for all keys)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1021892856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022656430
Merging it based in the tests results and 5 approvals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022133596
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1021893272
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1021615040
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022116267
> Hi @GutoVeronezi Is this good to go in 4.16.1? If so, please rebase with 4.16.
Hey @sureshanaparti, I'm good with it in main only, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5898: Fix camel case in some methods' names
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5898:
URL: https://github.com/apache/cloudstack/pull/5898#issuecomment-1022622755
<b>Trillian test result (tid-3014)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32758 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5898-t3014-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org