[Impala-ASF-CR] IMPALA-7360: sequence scanners sometimes skip blocks

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Hello Pranay Singh, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11062

to look at the new patch set (#2).

Change subject: IMPALA-7360: sequence scanners sometimes skip blocks
......................................................................

IMPALA-7360: sequence scanners sometimes skip blocks

The handling of sync markers after processing a block was broken - eos_
was set if the sync marker straddles the boundary. The expected
behaviour (documented by comments) in this case is that the current
scanner should process the next block, if there is one.

If you look at the logic before the IMPALA-3905 change in commit
931bf49cd90e496df6bf260ae668ec6944f0016c, it split the checking
of eosr() and eof() similar to this patch.

Testing:
Add regression tests that scans a large table with a variety of
different scan range lengths, with some randomisation to exercise
different edge cases. This reliably triggered the bug.

Change-Id: I49a70a4925b0271204b8eea4f980299d7654805a
---
M be/src/exec/base-sequence-scanner.cc
A testdata/workloads/tpch/queries/tpch-scan-range-lengths.test
M tests/query_test/test_scanners.py
3 files changed, 86 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/11062/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49a70a4925b0271204b8eea4f980299d7654805a
Gerrit-Change-Number: 11062
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Pranay Singh