You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2018/04/26 16:09:45 UTC
Review Request 66816: ATLAS-2600 : Glossary Term details page should
allow add/update/remove of classifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66816/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2600
https://issues.apache.org/jira/browse/ATLAS-2600
Repository: atlas
Description
-------
Patch contains following changes.
* Allow to add/update/remove of classifications to term
* Navigation issue fix
* When creating sub-category or term, multiple windows show up
* Deleting glossary/term/category doesn't prompt for user confirmation
* Classifications tab keeps loading forever if there are 25+ classifications
* Lineage is not displayed even it has DataSet as Supertype
Diffs
-----
dashboardv2/public/css/scss/override.scss 1815c1476
dashboardv2/public/js/router/Router.js d4cdf2602
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html a23797f3e
dashboardv2/public/js/templates/glossary/CreateEditGlossaryLayoutView_tmpl.html f783706bb
dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 25967ea51
dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html f29f4e7cf
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html b30023ed0
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 411aaab49
dashboardv2/public/js/utils/CommonViewFunction.js b7e2c72ae
dashboardv2/public/js/utils/Overrides.js a7bf3959f
dashboardv2/public/js/utils/Utils.js ff6b5ff4f
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js d0b700912
dashboardv2/public/js/views/glossary/AssignTermLayoutView.js fd7631d82
dashboardv2/public/js/views/glossary/CreateEditGlossaryLayoutView.js e06b05b86
dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 2ba3c45c5
dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 57c58c74b
dashboardv2/public/js/views/graph/RelationshipLayoutView.js 397deed3a
dashboardv2/public/js/views/profile/ProfileLayoutView.js d807f41d7
dashboardv2/public/js/views/schema/SchemaLayoutView.js 4bee67328
dashboardv2/public/js/views/search/SearchLayoutView.js e8405ee15
dashboardv2/public/js/views/search/SearchResultLayoutView.js 0318c32b5
dashboardv2/public/js/views/tag/TagDetailLayoutView.js d7f26e3f6
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 9125fc88c
dashboardv2/public/js/views/tag/TagLayoutView.js 796904101
Diff: https://reviews.apache.org/r/66816/diff/1/
Testing
-------
Done one round of sanity test
Thanks,
keval bhatt
Re: Review Request 66816: ATLAS-2600 : Glossary Term details page
should allow add/update/remove of classifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66816/#review202018
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 26, 2018, 4:09 p.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66816/
> -----------------------------------------------------------
>
> (Updated April 26, 2018, 4:09 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2600
> https://issues.apache.org/jira/browse/ATLAS-2600
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Patch contains following changes.
>
> * Allow to add/update/remove of classifications to term
> * Navigation issue fix
> * When creating sub-category or term, multiple windows show up
> * Deleting glossary/term/category doesn't prompt for user confirmation
> * Classifications tab keeps loading forever if there are 25+ classifications
> * Lineage is not displayed even it has DataSet as Supertype
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/override.scss 1815c1476
> dashboardv2/public/js/router/Router.js d4cdf2602
> dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html a23797f3e
> dashboardv2/public/js/templates/glossary/CreateEditGlossaryLayoutView_tmpl.html f783706bb
> dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 25967ea51
> dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html f29f4e7cf
> dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html b30023ed0
> dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 411aaab49
> dashboardv2/public/js/utils/CommonViewFunction.js b7e2c72ae
> dashboardv2/public/js/utils/Overrides.js a7bf3959f
> dashboardv2/public/js/utils/Utils.js ff6b5ff4f
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js d0b700912
> dashboardv2/public/js/views/glossary/AssignTermLayoutView.js fd7631d82
> dashboardv2/public/js/views/glossary/CreateEditGlossaryLayoutView.js e06b05b86
> dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 2ba3c45c5
> dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 57c58c74b
> dashboardv2/public/js/views/graph/RelationshipLayoutView.js 397deed3a
> dashboardv2/public/js/views/profile/ProfileLayoutView.js d807f41d7
> dashboardv2/public/js/views/schema/SchemaLayoutView.js 4bee67328
> dashboardv2/public/js/views/search/SearchLayoutView.js e8405ee15
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 0318c32b5
> dashboardv2/public/js/views/tag/TagDetailLayoutView.js d7f26e3f6
> dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 9125fc88c
> dashboardv2/public/js/views/tag/TagLayoutView.js 796904101
>
>
> Diff: https://reviews.apache.org/r/66816/diff/1/
>
>
> Testing
> -------
>
> Done one round of sanity test
>
>
> Thanks,
>
> keval bhatt
>
>