You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "sborya (via GitHub)" <gi...@apache.org> on 2023/01/25 22:15:43 UTC

[GitHub] [samza] sborya commented on a diff in pull request #1651: Migrate zkclient library

sborya commented on code in PR #1651:
URL: https://github.com/apache/samza/pull/1651#discussion_r1087204826


##########
build.gradle:
##########
@@ -220,11 +220,12 @@ project(":samza-core_$scalaSuffix") {
 
   dependencies {
     compile project(':samza-api')
-    compile("com.101tec:zkclient:$zkClientVersion") {
+    compile("org.apache.helix:zookeeper-api:1.1.0") {

Review Comment:
   Seems like the version is usually supplied as a variable and is set in a separate file. Should we keep the style here too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org