[GitHub] [geode] bschuchardt opened pull request #4124: GEODE-3780 suspected member is never watched again after passing fina…

["bschuchardt (GitHub)" <gi...@apache.org>]

…l check

This restores our original behavior (pre-1.0) behavior of performing a
final check on a member if UDP communications with that member fail.

We now also send exonoration messages to all other members if a suspect is
cleared.  We need to do that because another member may have sent a
Suspect message that was ignored because the suspect was already
undergoing a final check.

I also noticed that our tcp/ip final check loop was performing more than
one check in many cases because the nanosecond clock has a coarse
granularity.  A socket so-timeout based on the millisecond clock was
timing out but the nanosecond clock didn't line up with that timeout and
caused the "for" loop to make another attempt.  I changed that loop to
convert the nanosecond clock value to milliseconds.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4124 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] echobravopapa commented on issue #4124: GEODE-3780 suspected member is never watched again after passing fina…

["echobravopapa (GitHub)" <gi...@apache.org>]

looks like some JDK11 test failures...

[ Full content available at: https://github.com/apache/geode/pull/4124 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org