You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dheerajturaga (via GitHub)" <gi...@apache.org> on 2025/10/26 03:43:18 UTC
[PR] Better highlighting of selected task instance and edges in grid view [airflow]
dheerajturaga opened a new pull request, #57275:
URL: https://github.com/apache/airflow/pull/57275
The previous bold border didn't provide enough visual distinction for
selected tasks and their connections. This change adds a blue glow effect
and color highlighting to make selected elements stand out clearly.
https://github.com/user-attachments/assets/1a5f146c-00ae-4fd2-ad44-acf615dcd4bc
<img width="1918" height="1031" alt="image" src="https://github.com/user-attachments/assets/2e4d14af-40fb-41bf-b459-7d461545da0f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Better highlighting of selected task instance and edges in grid view [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #57275:
URL: https://github.com/apache/airflow/pull/57275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Better highlighting of selected task instance and edges in grid view [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #57275:
URL: https://github.com/apache/airflow/pull/57275#issuecomment-3457806709
I get the need to make it more obvious what is selected. I don't know if I agree with the drop shadow effect. Let's just change the border color and width.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Better highlighting of selected task instance and edges in grid view [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #57275:
URL: https://github.com/apache/airflow/pull/57275#issuecomment-3462055472
> > I get the need to make it more obvious what is selected. I don't know if I agree with the drop shadow effect. Let's just change the border color and width.
>
> Any reason for "don't know if agree"? Just layout nit, tooo fancy? Or any technical reason?
Colorful drop shadows just aren't part of our design language, so I would prefer to stay consistent and not add it one-off. Also, I think the border state color and the drop shadow color are clashing.
Perhaps we just override the border color when a task is selected? No information is lost since the state badge is always visible on the task node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Better highlighting of selected task instance and edges in grid view [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #57275:
URL: https://github.com/apache/airflow/pull/57275#issuecomment-3458526164
> I get the need to make it more obvious what is selected. I don't know if I agree with the drop shadow effect. Let's just change the border color and width.
Any reason for "don't know if agree"? Just layout nit, tooo fancy? Or any technical reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Better highlighting of selected task instance and edges in grid view [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57275:
URL: https://github.com/apache/airflow/pull/57275#issuecomment-3468268977
### Backport successfully created: v3-1-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/57560"><img src="https://img.shields.io/badge/PR-57560-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Better highlighting of selected task instance and edges in grid view [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #57275:
URL: https://github.com/apache/airflow/pull/57275#issuecomment-3465030214
> > > I get the need to make it more obvious what is selected. I don't know if I agree with the drop shadow effect. Let's just change the border color and width.
> >
> >
> > Any reason for "don't know if agree"? Just layout nit, tooo fancy? Or any technical reason?
>
> Colorful drop shadows just aren't part of our design language, so I would prefer to stay consistent and not add it one-off. Also, I think the border state color and the drop shadow color are clashing.
>
> Perhaps we just override the border color when a task is selected? No information is lost since the state badge is always visible on the task node.
Done!
<img width="1806" height="1304" alt="image" src="https://github.com/user-attachments/assets/f9234d84-a78e-4ee7-842d-ca94494665aa" />
<img width="1806" height="1298" alt="image" src="https://github.com/user-attachments/assets/3ef930f9-fc8b-44b1-a9f6-0b15f302dbd0" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org