You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/06 16:36:25 UTC
[GitHub] [solr] madrob commented on pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…
madrob commented on PR #965:
URL: https://github.com/apache/solr/pull/965#issuecomment-1238393512
The failure is ```/home/runner/work/solr/solr/solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java:238: warning: [NarrowCalculation] This product of integers could overflow before being implicitly cast to a long.
[41](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:42)
[42](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:43)
> Task :solr:solrj:compileJava
[43](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:44)
boolean round = rangeStep >= (1 << bits) * 16;
[44](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:45)
^
[45](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:46)
(see https://errorprone.info/bugpattern/NarrowCalculation)
[46](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:47)
Did you mean 'boolean round = rangeStep >= (1 << bits) * 16L;'?
[47](https://github.com/apache/solr/runs/8189262631?check_suite_focus=true#step:7:48)```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org