You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/06/10 13:53:54 UTC

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog 

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16058


Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................

IMPALA-7538: Support HDFS caching with LocalCatalog

This patch adds support for HDFS caching in LocalCatalog coordinators.
We use the same way catalogd propagates HdfsCachePools in catalog-v1.
They are cached in LocalCatalog coordinators as v1 and are not
“fetch-on-demand” since only cache pool names are cached.

The isMarkedCached markers of HdfsTable and HdfsPartition are also
propagated to the LocalCatalog coordinators for correctly handling
ShowTableStats and ShowPartitions statements with caching information.

Tests:
 - Revive hdfs caching related tests in metadata/test_ddl.py and
   query_test/test_hdfs_caching.py for LocalCatalog.

Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
---
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M tests/common/skip.py
M tests/metadata/test_ddl.py
M tests/query_test/test_hdfs_caching.py
13 files changed, 155 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/16058/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jun 2020 22:03:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6028/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jun 2020 17:09:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5981/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jun 2020 00:42:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 2:

(2 comments)

Thanks for the review!

Reexamined the code paths for global invalidation and catalogd restarts. Added more comments.

http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@92
PS1, Line 92: Pools() {
> I know this is not used currently, but such messages have a way to sneek in
Done


http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java:

http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@126
PS1, Line 126: es not necessarily mean
             :    * the data is cached
> just for my understanding what does this statement mean? When would a parti
These comments are copied from catalog-v1. I think one case is users can uncache the directories or sub-directories using hdfs commands.



-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 08:54:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 2: Code-Review+2

Patch makes sense to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jun 2020 17:09:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 1: Code-Review+1

Makes sense to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jun 2020 23:49:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jun 2020 17:09:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6268/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jun 2020 14:41:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jun 2020 05:47:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................

IMPALA-7538: Support HDFS caching with LocalCatalog

This patch adds support for HDFS caching in LocalCatalog coordinators.
We use the same way catalogd propagates HdfsCachePools in catalog-v1.
They are cached in LocalCatalog coordinators as v1 and are not
“fetch-on-demand” since only cache pool names are cached.

The isMarkedCached markers of HdfsTable and HdfsPartition are also
propagated to the LocalCatalog coordinators for correctly handling
ShowTableStats and ShowPartitions statements with caching information.

Tests:
 - Revive hdfs caching related tests in metadata/test_ddl.py and
   query_test/test_hdfs_caching.py for LocalCatalog.

Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Reviewed-on: http://gerrit.cloudera.org:8080/16058
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M tests/common/skip.py
M tests/metadata/test_ddl.py
M tests/query_test/test_hdfs_caching.py
13 files changed, 175 insertions(+), 34 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Patch looks good to me. Just a few minor comments below.

http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@92
PS1, Line 92: not supported
I know this is not used currently, but such messages have a way to sneek into real production deployments when we change defaults. May be just change to "HDFSCachePools are not supported in DirectMetaProvider"


http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java:

http://gerrit.cloudera.org:8080/#/c/16058/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@126
PS1, Line 126: Does not necessarily mean
             :    * the data is cached
just for my understanding what does this statement mean? When would a partition be marked as cached but data is not cached?



-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jun 2020 06:32:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16058

to look at the new patch set (#2).

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................

IMPALA-7538: Support HDFS caching with LocalCatalog

This patch adds support for HDFS caching in LocalCatalog coordinators.
We use the same way catalogd propagates HdfsCachePools in catalog-v1.
They are cached in LocalCatalog coordinators as v1 and are not
“fetch-on-demand” since only cache pool names are cached.

The isMarkedCached markers of HdfsTable and HdfsPartition are also
propagated to the LocalCatalog coordinators for correctly handling
ShowTableStats and ShowPartitions statements with caching information.

Tests:
 - Revive hdfs caching related tests in metadata/test_ddl.py and
   query_test/test_hdfs_caching.py for LocalCatalog.

Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
---
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M tests/common/skip.py
M tests/metadata/test_ddl.py
M tests/query_test/test_hdfs_caching.py
13 files changed, 175 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/16058/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-7538: Support HDFS caching with LocalCatalog

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16058 )

Change subject: IMPALA-7538: Support HDFS caching with LocalCatalog
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6334/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I661f7b76a9575f6f5b3fa2c6feebda1a5d7c3712
Gerrit-Change-Number: 16058
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 09:20:50 +0000
Gerrit-HasComments: No