Change in asterixdb[master]: [NO ISSUE][STO] Component Deletes Through flushes and merges

["Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>]

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Component Deletes Through flushes and merges
......................................................................


Patch Set 15:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2017/15/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java:

Line 254:     void deleteComponents(ILSMIndexOperationContext ctx, Predicate<ILSMComponent> predicate) throws HyracksDataException;
> MAJOR SonarQube violation:
what he said


https://asterix-gerrit.ics.uci.edu/#/c/2017/15/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:

PS15, Line 751: deleteComponents
Replace rollback by deletion in comments and logs


PS15, Line 763: fo
for


PS15, Line 775: try {
              :                 ioCallback.waitForIO();
              :             } catch (InterruptedException e) {
              :                 LOGGER.log(Level.WARNING, "Rollback has been interrupted. returning");
              :                 Thread.currentThread().interrupt();
              :                 throw HyracksDataException.create(e);
              :             }
How about you move this to a XUtil#waitOrElseThrow(ILSMIOOperationCallback, IndexOperation) and use it here and in the below wait?


PS15, Line 790: https://issues.apache.org/jira/browse/
remove the path


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2017
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178656207bfa1d15e6ae5ff2403a16df33940773
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes