You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 02:04:03 UTC

[GitHub] [airflow] kaxil opened a new pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

kaxil opened a new pull request #11873:
URL: https://github.com/apache/airflow/pull/11873


   As suggested by https://flask.palletsprojects.com/en/1.1.x/config/#SESSION_COOKIE_SAMESITE , set `cookie_samesite` to `Lax`.
   
   This Werkzeug bug prevented using latest version of Werkzeug (1.1.0): https://github.com/pallets/werkzeug/issues/1549 | https://github.com/pallets/werkzeug/pull/1550
   
   https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie
   Detailed explanantion: https://web.dev/samesite-cookies-explained/
   
   Previously https://github.com/apache/airflow/pull/11610 had unpinned Werkzeug but that caused https://github.com/apache/airflow/issues/11871 on 2.0.0a2 so I had to pin it again https://github.com/apache/airflow/pull/11872
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#issuecomment-716929591


   cc @ryanahamilton -- Please do let me know if I am doing something clearly wrong.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#discussion_r512675201



##########
File path: setup.py
##########
@@ -737,7 +737,6 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
     'typing-extensions>=3.7.4;python_version<"3.8"',
     'tzlocal>=1.4,<2.0.0',
     'unicodecsv>=0.14.1',
-    'werkzeug<1.0.0',

Review comment:
       Do we need `~1.1` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#issuecomment-717506444


   CI run: https://github.com/apache/airflow/actions/runs/331607969


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#issuecomment-717228427


   Not sure about Lax samesite as a default though. Let me re-read about it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#discussion_r512677636



##########
File path: setup.py
##########
@@ -737,7 +737,6 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
     'typing-extensions>=3.7.4;python_version<"3.8"',
     'tzlocal>=1.4,<2.0.0',
     'unicodecsv>=0.14.1',
-    'werkzeug<1.0.0',

Review comment:
       yes, updated https://github.com/apache/airflow/pull/11873/commits/729f1a2f5dd90cf815caf8f3877654e87f68e42b




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11873:
URL: https://github.com/apache/airflow/pull/11873


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#issuecomment-716929591


   cc @ryanahamilton 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb edited a comment on pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#issuecomment-717228427


   Not sure about Lax samesite as a default though. Let me re-read about it.
   
   Oh yeah Lax is probably okay. I wonder if we could have Airflow cope with Strict by redirecting once and setting/checking a cookie? Dunno.
   
   Anyway Lax good enough for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#discussion_r512760050



##########
File path: setup.py
##########
@@ -737,7 +737,7 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
     'typing-extensions>=3.7.4;python_version<"3.8"',
     'tzlocal>=1.4,<2.0.0',
     'unicodecsv>=0.14.1',
-    'werkzeug<1.0.0',
+    'werkzeug~=1.1.0',

Review comment:
       ```suggestion
       'werkzeug~=1.0, >=1.0.1',
   ```
   I guess.
   
   Also you should never trust me :D 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#discussion_r512677636



##########
File path: setup.py
##########
@@ -737,7 +737,6 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
     'typing-extensions>=3.7.4;python_version<"3.8"',
     'tzlocal>=1.4,<2.0.0',
     'unicodecsv>=0.14.1',
-    'werkzeug<1.0.0',

Review comment:
       yes, updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #11873: Unpin werkzeug & set default cookie_samesite to Lax

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11873:
URL: https://github.com/apache/airflow/pull/11873#issuecomment-717496146


   CI is green @ashb 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org