[GitHub] [arrow] lidavidm commented on a diff in pull request #34815: GH-34778: [Java] Add hook to further configure the ServerBuilder in FlightServer

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #34815:
URL: https://github.com/apache/arrow/pull/34815#discussion_r1154570100


##########
java/flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/ServerInterceptorAdapter.java:
##########
@@ -82,7 +82,14 @@ public ServerInterceptorAdapter(List<KeyFactory<?>> factories) {
   @Override
   public <ReqT, RespT> Listener<ReqT> interceptCall(ServerCall<ReqT, RespT> call, Metadata headers,
       ServerCallHandler<ReqT, RespT> next) {
-    final CallInfo info = new CallInfo(FlightMethod.fromProtocol(call.getMethodDescriptor().getFullMethodName()));
+    FlightMethod method;
+    try {
+      method = FlightMethod.fromProtocol(call.getMethodDescriptor().getFullMethodName());

Review Comment:
   I wonder if we could do something like check the service name instead, to avoid catching an exception + to avoid silently passing things through if we add new Flight methods in the future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org