You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/07 15:28:34 UTC
[GitHub] [hive] saihemanth-cloudera opened a new pull request #1380: Show tables in database with owner policy
saihemanth-cloudera opened a new pull request #1380:
URL: https://github.com/apache/hive/pull/1380
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Owner of the tables in DB will be able to see the tables while issuing the command "Show tables in database" without the need of ranger policy.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Owner of the tables should be able to see the tables.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
From spark-shell client and add a unit test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] saihemanth-cloudera commented on a change in pull request #1380: Show tables in database with owner policy
Posted by GitBox <gi...@apache.org>.
saihemanth-cloudera commented on a change in pull request #1380:
URL: https://github.com/apache/hive/pull/1380#discussion_r499079676
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java
##########
@@ -600,6 +600,22 @@ public void testReplDump() throws Exception {
assertEquals("table name", inDbTableName.toLowerCase(), dbObj.getObjectName());
}
+ @Test
+ public void showTablesInDB() throws Exception{
+ final String tableName1 = "table1";
+ driver.run("create table " + dbName+"."+tableName1 + "(eid int, yoj int)");
+ final String tableName2 = "table2";
+ driver.run("create table " + dbName+"."+tableName2 + "(eid int, ecode int)");
+ reset(mockedAuthorizer);
+
+ int status = driver.compile("show tables in "+dbName, true);
+ assertEquals(0, status);
+ Pair<List<HivePrivilegeObject>, List<HivePrivilegeObject>> io = getHivePrivilegeObjectInputs();
+ List<HivePrivilegeObject> inputs = io.getLeft();
+ HivePrivilegeObject dbObj = inputs.get(0);
+ assertEquals("input type", HivePrivilegeObjectType.DATABASE, dbObj.getType());
Review comment:
I have added the assert on owner info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yongzhi commented on a change in pull request #1380: Show tables in database with owner policy
Posted by GitBox <gi...@apache.org>.
yongzhi commented on a change in pull request #1380:
URL: https://github.com/apache/hive/pull/1380#discussion_r480541081
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -5695,8 +5695,16 @@ private void alter_table_core(String catName, String dbname, String name, Table
String[] parsedDbName = parseDbName(dbname, conf);
try {
ret = getMS().getTables(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], pattern);
- ret = FilterUtils.filterTableNamesIfEnabled(isServerFilterEnabled, filterHook,
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ if(ret != null && !ret.isEmpty()) {
+ List<Table> tableInfo = new ArrayList<>();
+ tableInfo = getMS().getTableObjectsByName(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ tableInfo = FilterUtils.filterTablesIfEnabled(isServerFilterEnabled, filterHook, tableInfo);
+ List<String> result = new ArrayList<>(); // Cannot do ret.clear() because of query cannot be modified error in tests.
+ for (Table tbl : tableInfo) {
+ result.add(tbl.getTableName());
+ }
+ return result;
Review comment:
Better follow the same pattern as the original function, return at the end.
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -5695,8 +5695,16 @@ private void alter_table_core(String catName, String dbname, String name, Table
String[] parsedDbName = parseDbName(dbname, conf);
try {
ret = getMS().getTables(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], pattern);
- ret = FilterUtils.filterTableNamesIfEnabled(isServerFilterEnabled, filterHook,
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ if(ret != null && !ret.isEmpty()) {
+ List<Table> tableInfo = new ArrayList<>();
+ tableInfo = getMS().getTableObjectsByName(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ tableInfo = FilterUtils.filterTablesIfEnabled(isServerFilterEnabled, filterHook, tableInfo);
Review comment:
Please add comments on why you pass-in tableInfo objects
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java
##########
@@ -600,6 +600,22 @@ public void testReplDump() throws Exception {
assertEquals("table name", inDbTableName.toLowerCase(), dbObj.getObjectName());
}
+ @Test
+ public void showTablesInDB() throws Exception{
+ final String tableName1 = "table1";
+ driver.run("create table " + dbName+"."+tableName1 + "(eid int, yoj int)");
+ final String tableName2 = "table2";
+ driver.run("create table " + dbName+"."+tableName2 + "(eid int, ecode int)");
+ reset(mockedAuthorizer);
+
+ int status = driver.compile("show tables in "+dbName, true);
+ assertEquals(0, status);
+ Pair<List<HivePrivilegeObject>, List<HivePrivilegeObject>> io = getHivePrivilegeObjectInputs();
+ List<HivePrivilegeObject> inputs = io.getLeft();
+ HivePrivilegeObject dbObj = inputs.get(0);
+ assertEquals("input type", HivePrivilegeObjectType.DATABASE, dbObj.getType());
Review comment:
Is that possible also to assert on owner related values?
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -5695,8 +5695,16 @@ private void alter_table_core(String catName, String dbname, String name, Table
String[] parsedDbName = parseDbName(dbname, conf);
try {
ret = getMS().getTables(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], pattern);
- ret = FilterUtils.filterTableNamesIfEnabled(isServerFilterEnabled, filterHook,
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ if(ret != null && !ret.isEmpty()) {
+ List<Table> tableInfo = new ArrayList<>();
+ tableInfo = getMS().getTableObjectsByName(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], ret);
+ tableInfo = FilterUtils.filterTablesIfEnabled(isServerFilterEnabled, filterHook, tableInfo);
+ List<String> result = new ArrayList<>(); // Cannot do ret.clear() because of query cannot be modified error in tests.
Review comment:
Not quite understand the comment. Maybe ret = new ArrayList<>(); good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yongzhi merged pull request #1380: Show tables in database with owner policy
Posted by GitBox <gi...@apache.org>.
yongzhi merged pull request #1380:
URL: https://github.com/apache/hive/pull/1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org