You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/09/28 00:27:46 UTC
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4547
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
[tools] introduced GetKuduCtlAbsolutePath()
This is a small clean-up on the Kudu command-line tools: the code
which returns the absolute path to the top-level kudu admin tool
is separated into GetKuduCtlAbsolutePath() utility method to avoid
code duplication.
Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
---
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
A src/kudu/tools/tool_util.cc
A src/kudu/tools/tool_util.h
6 files changed, 97 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/4547/1
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/CMakeLists.txt
File src/kudu/tools/CMakeLists.txt:
Line 32: add_library(kudu_tools_util
> This is a shipping library, yet tool_util.cc is test-only code. Maybe we ca
Done
http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/tool_util.cc
File src/kudu/tools/tool_util.cc:
Line 20: #ifndef KUDU_TOOLS_TOOL_UTIL_H_
> #pragma once
It seems it's a copy-and-paste artifact. Will remove.
http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/tool_util.h
File src/kudu/tools/tool_util.h:
Line 20: #ifndef KUDU_TOOLS_TOOL_UTIL_H_
> Use #pragma once instead.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4547
to look at the new patch set (#2).
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
[tools] introduced GetKuduCtlAbsolutePath()
This is a small clean-up on the Kudu command-line tools: the code
which returns the absolute path to the top-level kudu admin tool
is separated into GetKuduCtlAbsolutePath() utility method to avoid
code duplication.
Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
---
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
A src/kudu/tools/tool_test_util.cc
A src/kudu/tools/tool_test_util.h
6 files changed, 96 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/4547/2
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4547
to look at the new patch set (#3).
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
[tools] introduced GetKuduCtlAbsolutePath()
This is a small clean-up on the tests for the Kudu command-line tools.
Separated the code which returns the absolute path to the top-level
kudu admin tool into GetKuduCtlAbsolutePath() utility library to avoid
code duplication.
Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
---
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
A src/kudu/tools/tool_test_util.cc
A src/kudu/tools/tool_test_util.h
6 files changed, 97 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/4547/3
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4547/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
PS2, Line 85: ToolTest(): tool_path_(GetKuduCtlAbsolutePath()) {
> Nit: put the initializer list on the next line.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/CMakeLists.txt
File src/kudu/tools/CMakeLists.txt:
Line 32: add_library(kudu_tools_util
This is a shipping library, yet tool_util.cc is test-only code. Maybe we can find a better home for it?
http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/tool_util.cc
File src/kudu/tools/tool_util.cc:
Line 20: #ifndef KUDU_TOOLS_TOOL_UTIL_H_
#pragma once
http://gerrit.cloudera.org:8080/#/c/4547/1/src/kudu/tools/tool_util.h
File src/kudu/tools/tool_util.h:
Line 20: #ifndef KUDU_TOOLS_TOOL_UTIL_H_
Use #pragma once instead.
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4547/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
PS2, Line 85: ToolTest(): tool_path_(GetKuduCtlAbsolutePath()) {
Nit: put the initializer list on the next line.
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [tools] introduced GetKuduCtlAbsolutePath()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [tools] introduced GetKuduCtlAbsolutePath()
......................................................................
[tools] introduced GetKuduCtlAbsolutePath()
This is a small clean-up on the tests for the Kudu command-line tools.
Separated the code which returns the absolute path to the top-level
kudu admin tool into GetKuduCtlAbsolutePath() utility library to avoid
code duplication.
Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Reviewed-on: http://gerrit.cloudera.org:8080/4547
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
A src/kudu/tools/tool_test_util.cc
A src/kudu/tools/tool_test_util.h
6 files changed, 97 insertions(+), 46 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7109859fd4cbc6d380c358fd2c4dc3d00c6e874
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins