[GitHub] [dubbo] weixsun commented on a diff in pull request #10941: Upgrade to Spring Framework 6 and Spring Boot 3

[GitBox <gi...@apache.org>]

weixsun commented on code in PR #10941:
URL: https://github.com/apache/dubbo/pull/10941#discussion_r1022714747


##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java:
##########
@@ -307,9 +306,8 @@ public void postProcessMergedBeanDefinition(RootBeanDefinition beanDefinition, C
     }
 
     @Override
-    public PropertyValues postProcessPropertyValues(
-            PropertyValues pvs, PropertyDescriptor[] pds, Object bean, String beanName) throws BeansException {
-
+    public PropertyValues postProcessProperties(PropertyValues pvs, Object bean, String beanName)

Review Comment:
   `InstantiationAwareBeanPostProcessor#postProcessPropertyValues` removed as of Spring Framework 6.0.0, in favor of `postProcessProperties` method.



##########
dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/EmbeddedZooKeeper.java:
##########
@@ -83,7 +83,7 @@ public class EmbeddedZooKeeper implements SmartLifecycle {
      * Construct an EmbeddedZooKeeper with a random port.
      */
     public EmbeddedZooKeeper() {
-        clientPort = SocketUtils.findAvailableTcpPort();
+        clientPort = TestSocketUtils.findAvailableTcpPort();

Review Comment:
   `SocketUtils` has been removed in Spring Framework 6.0 M3. see [spring-projects/spring-framework#28052](https://github.com/spring-projects/spring-framework/issues/28052)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org