You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/05/29 14:56:05 UTC
Review Request: CLOUDSTACK-2130:UpdateDefaultNicForVirtualMachine api should
also create usage events for updating new default network
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11511/
-----------------------------------------------------------
Review request for cloudstack and mice xia.
Description
-------
The resource_name in usage_event table must refer to the NIC ID.
Updated the Events with old NIC Id.
This addresses bug CLOUDSTACK-2130.
Diffs
-----
server/src/com/cloud/vm/UserVmManagerImpl.java 5657877
Diff: https://reviews.apache.org/r/11511/diff/
Testing
-------
Manually tested.
Changed default NIC from id = 8 to 12.
select * from usage_event;
| 25 | NETWORK.OFFERING.REMOVE | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 | NULL | 1 | NULL | 0 |
| 26 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 12 | 8 | NULL | 1 | NULL | 0 |
| 27 | NETWORK.OFFERING.REMOVE | 2 | 2013-05-29 12:31:58 | 1 | 3 | 12 | 8 | NULL | 0 | NULL | 0 |
| 28 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 | NULL | 0 | NULL | 0 |
Thanks,
Saksham Srivastava
Re: Review Request: CLOUDSTACK-2130:UpdateDefaultNicForVirtualMachine api
should also create usage events for updating new default network
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11511/#review21182
-----------------------------------------------------------
Commit 62413eec1067ab5d92977fab93a2fc88d4247bb0 in branch refs/heads/master from Mice Xia <mi...@tcloudcomputing.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=62413ee ]
CLOUDSTACK-2130: Fix resource_name for old NIC ID
Signed-off-by: Mice Xia <mi...@tcloudcomputing.com>
- ASF Subversion and Git Services
On May 29, 2013, 12:56 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11511/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 12:56 p.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> The resource_name in usage_event table must refer to the NIC ID.
> Updated the Events with old NIC Id.
>
>
> This addresses bug CLOUDSTACK-2130.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java 5657877
>
> Diff: https://reviews.apache.org/r/11511/diff/
>
>
> Testing
> -------
>
> Manually tested.
> Changed default NIC from id = 8 to 12.
>
> select * from usage_event;
>
> | 25 | NETWORK.OFFERING.REMOVE | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 | NULL | 1 | NULL | 0 |
> | 26 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 12 | 8 | NULL | 1 | NULL | 0 |
> | 27 | NETWORK.OFFERING.REMOVE | 2 | 2013-05-29 12:31:58 | 1 | 3 | 12 | 8 | NULL | 0 | NULL | 0 |
> | 28 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 | NULL | 0 | NULL | 0 |
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request: CLOUDSTACK-2130:UpdateDefaultNicForVirtualMachine api
should also create usage events for updating new default network
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11511/#review21184
-----------------------------------------------------------
Ship it!
Ship It!
- mice xia
On May 29, 2013, 12:56 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11511/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 12:56 p.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> The resource_name in usage_event table must refer to the NIC ID.
> Updated the Events with old NIC Id.
>
>
> This addresses bug CLOUDSTACK-2130.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java 5657877
>
> Diff: https://reviews.apache.org/r/11511/diff/
>
>
> Testing
> -------
>
> Manually tested.
> Changed default NIC from id = 8 to 12.
>
> select * from usage_event;
>
> | 25 | NETWORK.OFFERING.REMOVE | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 | NULL | 1 | NULL | 0 |
> | 26 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 12 | 8 | NULL | 1 | NULL | 0 |
> | 27 | NETWORK.OFFERING.REMOVE | 2 | 2013-05-29 12:31:58 | 1 | 3 | 12 | 8 | NULL | 0 | NULL | 0 |
> | 28 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 | NULL | 0 | NULL | 0 |
>
>
> Thanks,
>
> Saksham Srivastava
>
>