You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/04 23:11:16 UTC

[GitHub] [flink] JingGe opened a new pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

JingGe opened a new pull request #17413:
URL: https://github.com/apache/flink/pull/17413


   ## What is the purpose of the change
   
   This pull request removes the duplicated code for arguments check.
   
   ## Brief change log
   
     - Consolidate the arguments check in the forBulkFileFormat(...) method that will be called by other method for different Format i.e. forRecordStreamFormat(...) and forRecordFileFormat(...). Duplicated code is therefore removed.
     - Rename method argument names from "reader" to ***Format to improve the code readability.
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *FileSourceTextLinesITCase* and *FileSourceHeavyThroughputTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17413:
URL: https://github.com/apache/flink/pull/17413#issuecomment-933925189

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f (Mon Oct 04 23:14:48 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #17413:
URL: https://github.com/apache/flink/pull/17413#issuecomment-933936118


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24764",
       "triggerID" : "3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24764) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17413:
URL: https://github.com/apache/flink/pull/17413#issuecomment-933936118


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

Posted by GitBox <gi...@apache.org>.

AHeise commented on pull request #17413:
URL: https://github.com/apache/flink/pull/17413#issuecomment-935781079


   Merged into master and 1.14.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise merged pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

Posted by GitBox <gi...@apache.org>.

AHeise merged pull request #17413:
URL: https://github.com/apache/flink/pull/17413


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17413: [hotfix][FileSource] internal refactoring to remove duplicated code without API change

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #17413:
URL: https://github.com/apache/flink/pull/17413#issuecomment-933936118


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24764",
       "triggerID" : "3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3aef5ddd2cdaaa619d5f1897c9bbaf6004a8c07f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24764) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org