You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "F64116045 (via GitHub)" <gi...@apache.org> on 2026/10/08 21:23:40 UTC

[PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

F64116045 opened a new pull request, #11449:
URL: https://github.com/apache/ozone/pull/11449

   ## What changes were proposed in this pull request?
   
   S3G currently calls GetS3VolumeContext before sending AbortMultiPartUpload.
   
   Add assumeS3Context support to the abort request so OM resolves the S3 volume before selecting the bucket layout. S3G can then send the abort request directly, reducing OM RPCs from two to one per AbortMultipartUpload request.
   
   Retain the existing flow for older OM versions.
   
   ## What is the link to the Apache JIRA?
   
   https://issues.apache.org/jira/browse/HDDS-16797
   
   ## How was this patch tested?
   
   
   Generated-by: Codex (GPT-6)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4301980673


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneManagerVersion.java:
##########
@@ -74,6 +74,9 @@ public enum OzoneManagerVersion implements ComponentVersion {
           + "client-side InfoBucket layout check for getFileChecksum"),
   ZDU(100, "OzoneManager version that supports zero downtime upgrade"),
 
+  S3_MULTIPART_UPLOAD_ABORT_CONTEXT(101,

Review Comment:
   thanks that was a great catch! updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #11449:
URL: https://github.com/apache/ozone/pull/11449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "chihsuan (via GitHub)" <gi...@apache.org>.
chihsuan commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4302297281


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -1937,6 +1942,7 @@ public void abortMultipartUpload(OmKeyArgs omKeyArgs) throws IOException {
     OMRequest omRequest = createOMRequest(
         Type.AbortMultiPartUpload)
         .setAbortMultiPartUploadRequest(multipartUploadAbortRequest.build())
+        .setAssumeS3Context(assumeS3Context)

Review Comment:
   nit: Would it be worth a unit test for this line? It seems only covered by `TestMultiTenantVolume`. Something like the test in #11479?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "chihsuan (via GitHub)" <gi...@apache.org>.
chihsuan commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4240090981


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneManagerVersion.java:
##########
@@ -74,6 +74,9 @@ public enum OzoneManagerVersion implements ComponentVersion {
           + "client-side InfoBucket layout check for getFileChecksum"),
   ZDU(100, "OzoneManager version that supports zero downtime upgrade"),
 
+  S3_MULTIPART_UPLOAD_ABORT_CONTEXT(101,

Review Comment:
   Just a heads up, #11458 also adds 101, so whichever merges second will need to bump. cc @rich7420



##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -622,6 +622,11 @@ default OmMultipartUploadCompleteInfo completeMultipartUpload(
         "this to be implemented, as write requests use a new approach.");
   }
 
+  /** Abort a multipart upload, optionally resolving its S3 volume on OM. */
+  default void abortMultipartUpload(OmKeyArgs omKeyArgs, boolean assumeS3Context) throws IOException {
+    throw new UnsupportedOperationException("Write requests are handled through OMClientRequest");

Review Comment:
   nit: Should we reuse the message from the neighboring methods for consistency?
   
   ```suggestion
       throw new UnsupportedOperationException("OzoneManager does not require " +
           "this to be implemented, as write requests use a new approach.");
   ```



##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/multitenant/TestMultiTenantVolume.java:
##########
@@ -186,6 +186,12 @@ public void testS3TenantVolume() throws Exception {
     ObjectStore store2 = getStoreForAccessID(UUID.randomUUID().toString());
     assertS3BucketNotFound(store2, BUCKET_NAME);
 
+    String keyName = "key";
+    String uploadID = bucket.initiateMultipartUpload(keyName).getUploadID();
+    store.getClientProxy().abortS3MultipartUpload(BUCKET_NAME, keyName, uploadID);

Review Comment:
   Could we also cover a link bucket in the tenant volume? The link may point to another volume with a different layout.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4301994281


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/execution/OMExecutionFlow.java:
##########
@@ -64,8 +64,10 @@ private OMResponse submitExecutionToRatis(OMRequest request, boolean isWrite) th
         omClientRequest = OzoneManagerRatisUtils.createClientRequest(request, ozoneManager);
         assert (omClientRequest != null);
         final OMClientRequest finalOmClientRequest = omClientRequest;
-        requestToSubmit = captureLatencyNs(perfMetrics.getPreExecuteLatencyNs(),
+        OMRequest preExecuted = captureLatencyNs(perfMetrics.getPreExecuteLatencyNs(),
             () -> finalOmClientRequest.preExecute(ozoneManager));
+        requestToSubmit = preExecuted.hasAssumeS3Context()
+            ? preExecuted.toBuilder().clearAssumeS3Context().build() : preExecuted;

Review Comment:
   added a new test, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on PR #11449:
URL: https://github.com/apache/ozone/pull/11449#issuecomment-6233921951

   Thanks @chihsuan for the thorough review !🙌


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "chihsuan (via GitHub)" <gi...@apache.org>.
chihsuan commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4301115309


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneManagerVersion.java:
##########
@@ -74,6 +74,9 @@ public enum OzoneManagerVersion implements ComponentVersion {
           + "client-side InfoBucket layout check for getFileChecksum"),
   ZDU(100, "OzoneManager version that supports zero downtime upgrade"),
 
+  S3_MULTIPART_UPLOAD_ABORT_CONTEXT(101,

Review Comment:
   I just found master already took 101. Could we bump this to the next free number? Git won't flag it as a conflict.



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/execution/OMExecutionFlow.java:
##########
@@ -64,8 +64,10 @@ private OMResponse submitExecutionToRatis(OMRequest request, boolean isWrite) th
         omClientRequest = OzoneManagerRatisUtils.createClientRequest(request, ozoneManager);
         assert (omClientRequest != null);
         final OMClientRequest finalOmClientRequest = omClientRequest;
-        requestToSubmit = captureLatencyNs(perfMetrics.getPreExecuteLatencyNs(),
+        OMRequest preExecuted = captureLatencyNs(perfMetrics.getPreExecuteLatencyNs(),
             () -> finalOmClientRequest.preExecute(ozoneManager));
+        requestToSubmit = preExecuted.hasAssumeS3Context()
+            ? preExecuted.toBuilder().clearAssumeS3Context().build() : preExecuted;

Review Comment:
   Could we add a `TestOMExecutionFlow` check that this clears the flag? The `assertFalse` was dropped in the move, so removing this line keeps unit tests green.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4240278453


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneManagerVersion.java:
##########
@@ -74,6 +74,9 @@ public enum OzoneManagerVersion implements ComponentVersion {
           + "client-side InfoBucket layout check for getFileChecksum"),
   ZDU(100, "OzoneManager version that supports zero downtime upgrade"),
 
+  S3_MULTIPART_UPLOAD_ABORT_CONTEXT(101,

Review Comment:
   Thanks for the heads-up. I’ll bump the OM version in #11458 if this merges first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on PR #11449:
URL: https://github.com/apache/ozone/pull/11449#issuecomment-6110638348

   thanks @chihsuan for the review, I've addressed the comment!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4242126360


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/multitenant/TestMultiTenantVolume.java:
##########
@@ -186,6 +186,12 @@ public void testS3TenantVolume() throws Exception {
     ObjectStore store2 = getStoreForAccessID(UUID.randomUUID().toString());
     assertS3BucketNotFound(store2, BUCKET_NAME);
 
+    String keyName = "key";
+    String uploadID = bucket.initiateMultipartUpload(keyName).getUploadID();
+    store.getClientProxy().abortS3MultipartUpload(BUCKET_NAME, keyName, uploadID);

Review Comment:
   Sure, added it!
   Also covered different layouts between the link and target bucket.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4310072638


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2340,6 +2340,23 @@ public OmMultipartUploadCompleteInfo completeMultipartUpload(
         omMultipartUploadCompleteList);
   }
 
+  @Override
+  public void abortS3MultipartUpload(String bucketName, String keyName, String uploadID) throws IOException {
+    if (!OzoneManagerVersion.S3_MULTIPART_UPLOAD_ABORT_CONTEXT.isSupportedBy(omVersion)) {
+      abortMultipartUpload(getS3VolumeContext().getOmVolumeArgs().getVolume(), bucketName, keyName, uploadID);
+      return;
+    }
+    verifyBucketName(bucketName);
+    HddsClientUtils.checkNotNull(keyName, uploadID);
+    OmKeyArgs keyArgs = new OmKeyArgs.Builder()
+        .setVolumeName(OzoneConfigKeys.OZONE_S3_VOLUME_NAME_DEFAULT)

Review Comment:
   nit: Could we keep the comment from `getS3KeyInfoWithVolumeContext` explaining the placeholder volume?
   
   ```suggestion
           // Volume name is not important, as OM resolves the S3 volume when assumeS3Context = true.
           .setVolumeName(OzoneConfigKeys.OZONE_S3_VOLUME_NAME_DEFAULT)
   ```



##########
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/rpc/TestRpcClient.java:
##########
@@ -359,6 +371,35 @@ public void testListMultipartUploadsValidatesNames(String volume, String bucket,
     }
   }
 
+  @ParameterizedTest
+  @EnumSource(value = OzoneManagerVersion.class,
+      names = {"GET_FILE_STATUS_REJECTS_OBS", "ZDU", "S3_MULTIPART_UPLOAD_ABORT_CONTEXT"})
+  void testAbortS3MultipartUpload(OzoneManagerVersion version) throws Exception {
+    RpcClient client = spy(createRpcClient());
+    try {
+      OzoneManagerClientProtocol om = mock(OzoneManagerClientProtocol.class);
+      FieldUtils.writeField(client, "omVersion", version, true);
+      FieldUtils.writeField(client, "ozoneManagerClient", om, true);
+      doReturn(new S3VolumeContext(OmVolumeArgs.newBuilder().setVolume("tenant-volume")
+          .setOwnerName("owner").setAdminName("admin").build(), "owner")).when(client).getS3VolumeContext();
+      boolean assumeContext = version == OzoneManagerVersion.S3_MULTIPART_UPLOAD_ABORT_CONTEXT;

Review Comment:
   Could this cover all versions, like `testCreateKeyIfNotExistsRequiresSupportedOmVersion` below? The hand-picked list skips `LIST_STATUS_REJECTS_OBS` (101), the version right below the new one, and `version == S3_MULTIPART_UPLOAD_ABORT_CONTEXT` would take the wrong branch once a newer OM version is added.
   
   ```suggestion
     @EnumSource(value = OzoneManagerVersion.class, mode = EnumSource.Mode.EXCLUDE, names = "UNKNOWN_VERSION")
     void testAbortS3MultipartUpload(OzoneManagerVersion version) throws Exception {
       RpcClient client = spy(createRpcClient());
       try {
         OzoneManagerClientProtocol om = mock(OzoneManagerClientProtocol.class);
         FieldUtils.writeField(client, "omVersion", version, true);
         FieldUtils.writeField(client, "ozoneManagerClient", om, true);
         doReturn(new S3VolumeContext(OmVolumeArgs.newBuilder().setVolume("tenant-volume")
             .setOwnerName("owner").setAdminName("admin").build(), "owner")).when(client).getS3VolumeContext();
         boolean assumeContext = OzoneManagerVersion.S3_MULTIPART_UPLOAD_ABORT_CONTEXT.isSupportedBy(version);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #11449:
URL: https://github.com/apache/ozone/pull/11449#issuecomment-6261365457

   Thanks @F64116045 for the patch. Thanks @chihsuan @rich7420 @adoroszlai for the reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on PR #11449:
URL: https://github.com/apache/ozone/pull/11449#issuecomment-6135880321

   > I'd lean toward the OMRequest approach in https://github.com/apache/ozone/pull/11479, so writes can clear it once before Ratis.
   
   Thanks, agree. moved `assumeS3Context` to OMRequest to match that PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "chihsuan (via GitHub)" <gi...@apache.org>.
chihsuan commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4246971777


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -622,6 +622,12 @@ default OmMultipartUploadCompleteInfo completeMultipartUpload(
         "this to be implemented, as write requests use a new approach.");
   }
 
+  /** Abort a multipart upload, optionally resolving its S3 volume on OM. */

Review Comment:
   nit: Could we mention that OM replaces the volume in `omKeyArgs` when `assumeS3Context` is true?
   
   ```suggestion
     /**
      * Abort a multipart upload.
      * @param assumeS3Context if true, OM resolves the S3 volume and ignores the volume in omKeyArgs.
      */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4242081460


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -622,6 +622,11 @@ default OmMultipartUploadCompleteInfo completeMultipartUpload(
         "this to be implemented, as write requests use a new approach.");
   }
 
+  /** Abort a multipart upload, optionally resolving its S3 volume on OM. */
+  default void abortMultipartUpload(OmKeyArgs omKeyArgs, boolean assumeS3Context) throws IOException {
+    throw new UnsupportedOperationException("Write requests are handled through OMClientRequest");

Review Comment:
   yes, updated. thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "F64116045 (via GitHub)" <gi...@apache.org>.
F64116045 commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4253758276


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -622,6 +622,12 @@ default OmMultipartUploadCompleteInfo completeMultipartUpload(
         "this to be implemented, as write requests use a new approach.");
   }
 
+  /** Abort a multipart upload, optionally resolving its S3 volume on OM. */

Review Comment:
   updated, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11449:
URL: https://github.com/apache/ozone/pull/11449#issuecomment-6260192337

   > lgtm. Just two minor comments
   
   Thanks @smengcl for the review.  Some recommendations on improving the flow:
   
   - if the suggested changes are completely optional, please mention that it's OK to merge without addressing them
   - if you are happy with someone making these changes in follow-up, please create the follow-up ticket (low prio, "GoodForNewContributors") and link it here
   - if the comments should be addressed in this PR, please don't approve nor trigger CI, otherwise the approval is confusing and the run unnecessary


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16797. S3G: Avoid calling getS3Volume in ABORT_MULTIPART_UPLOAD [ozone]

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #11449:
URL: https://github.com/apache/ozone/pull/11449#issuecomment-6261361973

   @adoroszlai Neither issue is blocking thus the +1. CI is green. I will go ahead and merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org