[GitHub] [spark] HyukjinKwon commented on a change in pull request #34822: [SPARK-37561][SQL] Avoid loading all functions when obtaining hive's DelegationToken

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34822:
URL: https://github.com/apache/spark/pull/34822#discussion_r763647155



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/security/HiveDelegationTokenProvider.scala
##########
@@ -99,7 +99,12 @@ private[spark] class HiveDelegationTokenProvider
         s"$principal at $metastoreUri")
 
       doAsRealUser {
-        val hive = Hive.get(conf, classOf[HiveConf])
+        val hive = conf match {
+          case hiveConf: HiveConf =>
+            Hive.getWithoutRegisterFns(hiveConf)

Review comment:
       we will have to nunuc https://github.com/apache/spark/blob/116255d10989fd87d1eb3347bb279df207b1b5c4/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L204-L211 approach to allow other versions of hive when buidling. cc @AngersZhuuuu FYI




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org