You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by tequalsme <gi...@git.apache.org> on 2017/05/09 18:21:12 UTC
[GitHub] nifi pull request #1776: NIFI-3858 PostHTTP support for custom headers via d...
GitHub user tequalsme opened a pull request:
https://github.com/apache/nifi/pull/1776
NIFI-3858 PostHTTP support for custom headers via dynamic properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tequalsme/nifi nifi-3858
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1776
----
commit 3a688296333ba006d820ac163a5c5d213cff397e
Author: Tim Reardon <te...@gmail.com>
Date: 2017-05-09T18:20:14Z
NIFI-3858 PostHTTP support for custom headers via dynamic properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1776: NIFI-3858 PostHTTP support for custom headers via dynamic ...
Posted by tequalsme <gi...@git.apache.org>.
Github user tequalsme commented on the issue:
https://github.com/apache/nifi/pull/1776
@jvwing Thanks for reviewing. This was a feature that my team added to our Nifi fork some time ago. I think it was done because the existing functionality does not support regular expressions, and was found to be more cumbersome to use than simply setting dynamic attributes. However I agree with your point that it doesn't make sense to have two custom header methods, so I will close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1776: NIFI-3858 PostHTTP support for custom headers via dynamic ...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1776
Are you aware that PostHTTP already supports custom headers via the "Attributes to Send as HTTP Headers (Regex)" property? Without the existing feature, I would find the dynamic attribute method intuitive enough. But I'm concerned about having two custom header methods, especially when they potentially conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1776: NIFI-3858 PostHTTP support for custom headers via dynamic ...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1776
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1776: NIFI-3858 PostHTTP support for custom headers via d...
Posted by tequalsme <gi...@git.apache.org>.
Github user tequalsme closed the pull request at:
https://github.com/apache/nifi/pull/1776
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---