You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/09/07 10:26:22 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4786: Update object_store chrono deprecations

tustvold commented on code in PR #4786:
URL: https://github.com/apache/arrow-rs/pull/4786#discussion_r1318407443


##########
object_store/src/util.rs:
##########
@@ -32,8 +32,9 @@ where
     D: serde::Deserializer<'de>,
 {
     let s: String = serde::Deserialize::deserialize(deserializer)?;
-    chrono::TimeZone::datetime_from_str(&chrono::Utc, &s, RFC1123_FMT)
-        .map_err(serde::de::Error::custom)
+    let naive = chrono::NaiveDateTime::parse_from_str(&s, RFC1123_FMT)

Review Comment:
   RFC1123_FMT does not contain a timezone, it is fixed to GMT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org