[GitHub] [iceberg] pvary commented on a change in pull request #3790: Test: Make sure to delete temp folders

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r777426801



##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -287,7 +285,11 @@ public void testCreateNamespace() throws TException {
         AlreadyExistsException.class, "Namespace '" + namespace1 + "' already exists!", () -> {
           catalog.createNamespace(namespace1);
         });
-    ImmutableMap newMeta = ImmutableMap.<String, String>builder()
+    String hiveLocalDir = temp.newFolder().toURI().toString();
+    if (hiveLocalDir.endsWith("/")) {

Review comment:
       I would remove this change in the nape of simplicity until we find some concrete use-cases where the tests are failing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org