You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jd...@apache.org on 2012/06/04 23:33:37 UTC
svn commit: r1346168 - in /lucene/dev/trunk/solr:
core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java
example/solr/conf/solrconfig.xml
solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java
Author: jdyer
Date: Mon Jun 4 21:33:36 2012
New Revision: 1346168
URL: http://svn.apache.org/viewvc?rev=1346168&view=rev
Log:
SOLR-2993: revert r1346116
Modified:
lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java
lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
lucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java?rev=1346168&r1=1346167&r2=1346168&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/ConjunctionSolrSpellChecker.java Mon Jun 4 21:33:36 2012
@@ -19,7 +19,6 @@ package org.apache.solr.spelling;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
@@ -136,12 +135,8 @@ public class ConjunctionSolrSpellChecker
//TODO: This just interleaves the results. In the future, we might want to let users give each checker its
// own weight and use that in combination to score & frequency to sort the results ?
private SpellingResult mergeCheckers(SpellingResult[] results, int numSug) {
- Map<Token, Integer> combinedTokenFrequency = new HashMap<Token, Integer>();
Map<Token, List<LinkedHashMap<String, Integer>>> allSuggestions = new LinkedHashMap<Token, List<LinkedHashMap<String, Integer>>>();
for(SpellingResult result : results) {
- if(result.getTokenFrequency()!=null) {
- combinedTokenFrequency.putAll(result.getTokenFrequency());
- }
for(Map.Entry<Token, LinkedHashMap<String, Integer>> entry : result.getSuggestions().entrySet()) {
List<LinkedHashMap<String, Integer>> allForThisToken = allSuggestions.get(entry.getKey());
if(allForThisToken==null) {
@@ -166,10 +161,6 @@ public class ConjunctionSolrSpellChecker
anyData = true;
Map.Entry<String,Integer> corr = iter.next();
combinedResult.add(original, corr.getKey(), corr.getValue());
- Integer tokenFrequency = combinedTokenFrequency.get(original);
- if(tokenFrequency!=null) {
- combinedResult.addFrequency(original, tokenFrequency);
- }
if(++numberAdded==numSug) {
break;
}
@@ -179,9 +170,7 @@ public class ConjunctionSolrSpellChecker
break;
}
}
- }
-
-
+ }
return combinedResult;
}
Modified: lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml?rev=1346168&r1=1346167&r2=1346168&view=diff
==============================================================================
--- lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml (original)
+++ lucene/dev/trunk/solr/example/solr/conf/solrconfig.xml Mon Jun 4 21:33:36 2012
@@ -1245,7 +1245,7 @@
collations (re-written queries) can include a combination of
corrections from both spellcheckers -->
<str name="spellcheck.dictionary">default</str>
- <str name="spellcheck.dictionary">wordbreak</str>
+ <!--str name="spellcheck.dictionary">wordbreak</str-->
<str name="spellcheck">on</str>
<str name="spellcheck.extendedResults">true</str>
<str name="spellcheck.count">10</str>
Modified: lucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java?rev=1346168&r1=1346167&r2=1346168&view=diff
==============================================================================
--- lucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java (original)
+++ lucene/dev/trunk/solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java Mon Jun 4 21:33:36 2012
@@ -56,9 +56,10 @@ public class TestSpellCheckResponse exte
server.add(doc);
server.commit(true, true);
- SolrQuery query = new SolrQuery("name:samsang");
+ SolrQuery query = new SolrQuery("*:*");
query.set(CommonParams.QT, "/spell");
query.set("spellcheck", true);
+ query.set(SpellingParams.SPELLCHECK_Q, "samsang");
query.set(SpellingParams.SPELLCHECK_BUILD, true);
QueryRequest request = new QueryRequest(query);
SpellCheckResponse response = request.process(server).getSpellCheckResponse();