You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by ak...@apache.org on 2005/03/25 21:13:39 UTC
svn commit: r159055 - in
directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search:
AndRule.java OrRule.java
Author: akarasulu
Date: Fri Mar 25 12:13:37 2005
New Revision: 159055
URL: http://svn.apache.org/viewcvs?view=rev&rev=159055
Log:
dang sorry gotta roll out this patch it breaks a bunch of test cases
Modified:
directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java?view=diff&r1=159054&r2=159055
==============================================================================
--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java (original)
+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java Fri Mar 25 12:13:37 2005
@@ -138,8 +138,7 @@
while( getDigester().peek() instanceof ExprNode )
{
- // TODO correct obvious performance hit here if this code stays around.
- node.addNodeToHead( ( ExprNode ) getDigester().pop() );
+ node.addNode( ( ExprNode ) getDigester().pop() );
}
if ( getDigester().peek() == this )
@@ -154,6 +153,10 @@
throw new IllegalStateException( msg );
}
+
+ StringBuffer strbuf = new StringBuffer( );
+
+ node.printToBuffer( strbuf );
getDigester().push( node );
}
Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java?view=diff&r1=159054&r2=159055
==============================================================================
--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java (original)
+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java Fri Mar 25 12:13:37 2005
@@ -140,8 +140,7 @@
while( getDigester().peek() instanceof ExprNode )
{
- // TODO correct obvious performance hit here if this code stays around.
- node.addNodeToHead( ( ExprNode ) getDigester().pop() );
+ node.addNode( ( ExprNode ) getDigester().pop() );
}
if ( getDigester().peek() == this )
@@ -156,6 +155,10 @@
throw new IllegalStateException( msg );
}
+
+ StringBuffer strbuf = new StringBuffer( );
+
+ node.printToBuffer( strbuf );
getDigester().push( node );
}