You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2010/12/21 19:44:03 UTC
[jira] Updated: (LUCENE-2828) SimilarityDelegator broke back-compat
for subclasses overriding lengthNorm
[ https://issues.apache.org/jira/browse/LUCENE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-2828:
---------------------------------------
Attachment: LUCENE-2828.patch
Patch w/ test case showing the failure.
> SimilarityDelegator broke back-compat for subclasses overriding lengthNorm
> --------------------------------------------------------------------------
>
> Key: LUCENE-2828
> URL: https://issues.apache.org/jira/browse/LUCENE-2828
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 3.0.3
> Reporter: Michael McCandless
> Attachments: LUCENE-2828.patch
>
>
> In LUCENE-1420, we added Similarity.computeNorm to let the norm computation have access to the raw information (length, boost, etc.).
> But this class broke back compat with SimilarityDelegator. We did add computeNorm there, but, it's impl just forwards to the delegee's computeNorm. In the case where a subclass of SimilarityDelegator overrides lengthNorm, that method will no longer be invoked.
> Not quite sure how to fix this since, somehow, we have to determine whether the delegee's impl of computeNorm should be favored over the subclasses impl of the "legacy" lengthNorm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org