You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by lokeshrajaram <gi...@git.apache.org> on 2015/06/04 09:00:59 UTC
[GitHub] flink pull request: Enforce import restriction on usage of Flink s...
GitHub user lokeshrajaram opened a pull request:
https://github.com/apache/flink/pull/775
Enforce import restriction on usage of Flink shaded package and Commons Validate
https://issues.apache.org/jira/browse/FLINK-2155
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lokeshrajaram/flink enforce_import_restriction
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #775
----
commit 733c704b094c2d7a19351e43d6338ccc774d02df
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-05-28T04:29:33Z
Merge pull request #1 from apache/master
update from original
commit 3b1c2eb8aa98f9176007f7e7a9cb3e973fdc4a02
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-03T06:22:12Z
getting latest
Merge branch 'master' of https://github.com/apache/flink
commit f14a0626092e68a2670cfe242bb44dd877d005cb
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-04T04:12:55Z
added illegal import restrictions module
commit f33a0f33a770b5a8fe40e35451a3e1058b990c42
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-04T06:41:21Z
added package import restriction check and restriction check for using Commons Validate
commit 9188d804e84a350848fed7d01c1a698d0bcfbaea
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-04T06:45:44Z
Merge branch 'master' of https://github.com/apache/flink
commit 110d1dfe579284c8cc9fe4851aa3ddeaf8cdbea2
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-04T04:12:55Z
added illegal import restrictions module
commit 536ba194af1888a2d5bff91070bbb4fa14f450da
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-04T06:41:21Z
added package import restriction check and restriction check for using Commons Validate
commit a600dc5a35bb5b60cacb70019c49b987b0896e11
Author: Lokesh Rajaram <ra...@gmail.com>
Date: 2015-06-04T06:48:27Z
Merge branch 'enforce_import_restriction' of https://github.com/lokeshrajaram/flink into enforce_import_restriction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Enforce import restriction on usage of Flink s...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/775#issuecomment-108760386
Cool, thank you.
You can update the pull request by force-pushing into the branch it is based on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Enforce import restriction on usage of Flink s...
Posted by lokeshrajaram <gi...@git.apache.org>.
Github user lokeshrajaram commented on the pull request:
https://github.com/apache/flink/pull/775#issuecomment-108760193
Thanks @rmetzger. will do that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Enforce import restriction on usage of Flink s...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/775#issuecomment-108758033
+1 change looks good.
Can you squash your changes into one commit, named
`[FLINK-2155] Enforce import restriction on usage of Flink shaded package and Commons Validate`
That makes merging for us easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Enforce import restriction on usage of Flink s...
Posted by lokeshrajaram <gi...@git.apache.org>.
Github user lokeshrajaram closed the pull request at:
https://github.com/apache/flink/pull/775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---