You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/02 02:07:05 UTC
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17377: [Improve][broker] Improve `replicatorDispacherRate` endpoint to pure async.
gaoran10 commented on code in PR #17377:
URL: https://github.com/apache/pulsar/pull/17377#discussion_r961227898
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -1100,13 +1100,31 @@ public void deleteSubscriptionDispatchRate(@Suspended AsyncResponse asyncRespons
@Path("/{tenant}/{cluster}/{namespace}/replicatorDispatchRate")
@ApiOperation(value = "Set replicator dispatch-rate throttling for all topics of the namespace")
@ApiResponses(value = {@ApiResponse(code = 403, message = "Don't have admin permission")})
- public void setReplicatorDispatchRate(
- @PathParam("tenant") String tenant,
- @PathParam("cluster") String cluster, @PathParam("namespace") String namespace,
+ public void setReplicatorDispatchRate(@Suspended AsyncResponse asyncResponse,
+ @PathParam("tenant") String tenant,
+ @PathParam("cluster") String cluster,
+ @PathParam("namespace") String namespace,
@ApiParam(value = "Replicator dispatch rate for all topics of the specified namespace")
- DispatchRateImpl dispatchRate) {
+ DispatchRateImpl dispatchRate) {
validateNamespaceName(tenant, cluster, namespace);
- internalSetReplicatorDispatchRate(dispatchRate);
+ validateSuperUserAccessAsync()
+ .thenAccept(__ -> {
+ log.info("[{}] Set namespace replicator dispatch-rate {}/{}",
+ clientAppId(), namespaceName, dispatchRate);
+ }).thenCompose(__ -> namespaceResources().setPoliciesAsync(namespaceName, policies -> {
+ String clusterName = pulsar().getConfiguration().getClusterName();
+ policies.replicatorDispatchRate.put(clusterName, dispatchRate);
+ return policies;
Review Comment:
Maybe we could add a method for this code block. It seems that v1 and v2 have the same behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org