You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Harrison Tarr (JIRA)" <ji...@apache.org> on 2018/05/10 19:08:00 UTC
[jira] [Comment Edited] (FELIX-5849) ConfigurationHandler
improperly removes backslashes because it treats them as escape characters
[ https://issues.apache.org/jira/browse/FELIX-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470945#comment-16470945 ]
Harrison Tarr edited comment on FELIX-5849 at 5/10/18 7:07 PM:
---------------------------------------------------------------
Hi [~cziegeler], do you have a link to that code? In my PR that i linked in the description, without my (admittedly heavy-handed) changes, that test fails. I think it should pass. I'm also not fully clear on why the reader is trying to handle escape characters in the first place. If you could give a quick explanation of that, I would appreciate it. Just trying to understand how the {{ConfigurationHandler}} works some more.
was (Author: harrison-tarr):
Hi Carsten, do you have a link to that code? In my PR that i linked in the description, without my (admittedly heavy-handed) changes, that test fails. I think it should pass. I'm also not fully clear on why the reader is trying to handle escape characters in the first place. If you could give a quick explanation of that, I would appreciate it. Just trying to understand how the {{ConfigurationHandler}} works some more.
> ConfigurationHandler improperly removes backslashes because it treats them as escape characters
> -----------------------------------------------------------------------------------------------
>
> Key: FELIX-5849
> URL: https://issues.apache.org/jira/browse/FELIX-5849
> Project: Felix
> Issue Type: Bug
> Components: Configuration Admin
> Reporter: Harrison Tarr
> Priority: Minor
>
> We use Felix in our Karaf project. I noticed when using a Windows-style path as a configuration, the backslashes were getting removed. I think I tracked it to the {{ConfigurationHandler}}. I wrote some unit tests to highlight the issue and came up with a fix. It can be found here [https://github.com/apache/felix/pull/136]
>
> I have not verified that it fixes my issue, but I think the unit tests highlight a bug anyway. My changes do not cause any of the other unit tests to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)