You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "apurv-1 (via GitHub)" <gi...@apache.org> on 2023/11/18 13:16:35 UTC
[PR] UI: Keyboard Shortcuts [cloudstack]
apurv-1 opened a new pull request, #8250:
URL: https://github.com/apache/cloudstack/pull/8250
### Description
Add the support to navigate through CloudStack Management UI with Keyboard.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2068178862
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2063238745
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2068195197
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2063267447
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8250 (QA-JID-315)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2065845977
> @DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.
Agree, @apurv-1 . I think this would be a good topic to start a [new discussion](https://github.com/apache/cloudstack/discussions/new/choose) on ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcut(s) [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2078746688
@vladimirpetrov , do you think that needs to be implemented before we can merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2063382347
@harikrishna-patnala @shwstppr @borisstoyanov let's merge this finaly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcut(s) [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2077365412
Hi @apurv-1, I tested the feature but it seems that the 'r' shortcut doesn't work on the following pages:
- 'Domains' page
- 'Infrastructure' summary page
- 'Infrastructure' - CPU sockets page
- 'Infrastructure' - DB/Usage server page
- 'Configuration' - Global Settings
- 'Tools' - Import-Export Instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1827389765
> > @apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
> > Will you add the other shortcuts from the old PR as well?
>
> Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)
ok, so do you want this merged as is or add to it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1827391799
@apurv-1 please see the failures in the UI build: https://github.com/apache/cloudstack/actions/runs/6914183873/job/18841522093?pr=8250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2063226724
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8250?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 31.22%. Comparing base [(`0bc7fb5`)](https://app.codecov.io/gh/apache/cloudstack/commit/0bc7fb540a4ac79c4697b0244a10a9169b86af25?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4082d43`)](https://app.codecov.io/gh/apache/cloudstack/pull/8250?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 268 commits behind head on main.
> :exclamation: Current head 4082d43 differs from pull request most recent head b0ecf89. Consider uploading reports for the commit b0ecf89 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8250 +/- ##
============================================
+ Coverage 30.75% 31.22% +0.47%
+ Complexity 33910 31081 -2829
============================================
Files 5341 4839 -502
Lines 374759 338361 -36398
Branches 54510 48669 -5841
============================================
- Hits 115248 105657 -9591
+ Misses 244276 218202 -26074
+ Partials 15235 14502 -733
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `25.15% <ø> (+0.50%)` | :arrow_up: |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.81% <ø> (-1.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8250?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "apurv-1 (via GitHub)" <gi...@apache.org>.
apurv-1 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1817509154
@borisstoyanov do we show the list of keyboard shortkeys in a different way? `for eg: github (shift+?)`
cc: @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1827326617
@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
Will you add the other shortcuts from the old PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1851719657
@apurv-1 thanks for the PR (again), could you resolve the conflict? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "apurv-1 (via GitHub)" <gi...@apache.org>.
apurv-1 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1852299211
> @apurv-1 thanks for the PR (again), could you resolve the conflict? Thanks.
Yeah, Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1827205313
Excellent, thanks for raising this @apurv-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1818461379
nice, great to see you back on this @apurv-1! The list you suggest seems good, let me know if you need any help/testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #8250: UI: Keyboard Shortcuts
URL: https://github.com/apache/cloudstack/pull/8250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2063239783
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2068178330
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcut(s) [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2082353265
Well, I think we should be consistent - wherever there is a 'Refresh' button, the shortcut must work, so yes, @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1818777377
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1818763213
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "apurv-1 (via GitHub)" <gi...@apache.org>.
apurv-1 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1827636836
> > > @apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
> > > Will you add the other shortcuts from the old PR as well?
> >
> >
> > Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)
>
> ok, so do you want this merged as is or add to it first?
I will add the more shortcuts then add the dialog then it will be ready for merge. Sorry, for confusion will change this to draft PR 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "apurv-1 (via GitHub)" <gi...@apache.org>.
apurv-1 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1827370108
> @apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
>
> Will you add the other shortcuts from the old PR as well?
Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1836125794
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1818509115
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`eaa4123`)](https://app.codecov.io/gh/apache/cloudstack/commit/eaa4123068a43dc3e0935407f8b55c000472598b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 29.12% compared to head [(`4082d43`)](https://app.codecov.io/gh/apache/cloudstack/pull/8250?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 16.20%.
> Report is 4 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8250 +/- ##
=============================================
- Coverage 29.12% 16.20% -12.93%
+ Complexity 31016 14087 -16929
=============================================
Files 5193 4705 -488
Lines 366268 316391 -49877
Branches 53550 44698 -8852
=============================================
- Hits 106674 51261 -55413
- Misses 244976 257959 +12983
+ Partials 14618 7171 -7447
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.20% <ø> (-8.86%)` | :arrow_down: |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8250?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-1818803650
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8250 (QA-JID-228)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "apurv-1 (via GitHub)" <gi...@apache.org>.
apurv-1 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2065736748
@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "apurv-1 (via GitHub)" <gi...@apache.org>.
apurv-1 commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2068184762
> > @DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.
>
> Agree, @apurv-1 . I think this would be a good topic to start a [new discussion](https://github.com/apache/cloudstack/discussions/new/choose) on ;)
@DaanHoogland started a discussion [here](https://github.com/apache/cloudstack/discussions/8955) :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Keyboard Shortcuts [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8250:
URL: https://github.com/apache/cloudstack/pull/8250#issuecomment-2063224308
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org