[GitHub] [spark] bozhang2820 commented on a diff in pull request #41575: [SPARK-38477][CORE] Use error class in org.apache.spark.shuffle

["bozhang2820 (via GitHub)" <gi...@apache.org>]

bozhang2820 commented on code in PR #41575:
URL: https://github.com/apache/spark/pull/41575#discussion_r1243878899


##########
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala:
##########
@@ -263,7 +264,8 @@ private[spark] class IndexShuffleBlockResolver(
             file.delete()
           }
           if (!fileTmp.renameTo(file)) {
-            throw new IOException(s"fail to rename file ${fileTmp} to ${file}")
+            throw SparkException.internalError(

Review Comment:
   Sorry for the late reply. Yes I think we might need a `SparkIOException` which extends `IOException`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org