You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2015/01/13 08:31:23 UTC

trafficserver git commit: TS-3287 Fix jtest coverity warnings, this fixes what I think was a slightly broken fix from before.

Repository: trafficserver
Updated Branches:
  refs/heads/master fbc0407c9 -> 39d8c57b2


TS-3287 Fix jtest coverity warnings, this fixes what I think was a
slightly broken fix from before.

Coverity CID #1021678


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/39d8c57b
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/39d8c57b
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/39d8c57b

Branch: refs/heads/master
Commit: 39d8c57b2a11b40856b7f35d6f8a2c1aa3770dbc
Parents: fbc0407
Author: Leif Hedstrom <zw...@apache.org>
Authored: Tue Jan 13 00:25:58 2015 -0700
Committer: Leif Hedstrom <zw...@apache.org>
Committed: Tue Jan 13 00:30:10 2015 -0700

----------------------------------------------------------------------
 tools/jtest/jtest.cc | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/39d8c57b/tools/jtest/jtest.cc
----------------------------------------------------------------------
diff --git a/tools/jtest/jtest.cc b/tools/jtest/jtest.cc
index 65a5ec2..aca327e 100644
--- a/tools/jtest/jtest.cc
+++ b/tools/jtest/jtest.cc
@@ -388,7 +388,6 @@ struct FD {
 
   void reset() {
     next = 0;
-    nalternate = 0;
     fd = -1;
     read_cb = NULL;
     write_cb = NULL;
@@ -408,7 +407,6 @@ struct FD {
     bytes = 0;
     doc = 0.0;
     doc_length = 0;
-    binary = 0;
     ims = 0;
     drop_after_CL = ::drop_after_CL;
     client_abort = 0;
@@ -416,13 +414,14 @@ struct FD {
     ftp_mode = FTP_NULL;
     ftp_peer_addr = 0;
     ftp_peer_port = 0;
-    ink_zero(name);
   }
 
   void close();
-  FD() {
-    req_header = 0; base_url = 0; keepalive = 0;
-    response_header = 0; ftp_data_fd = 0;
+  FD()
+    : base_url(NULL), req_header(NULL), response_header(NULL), keepalive(0), nalternate(0), ip(0), binary(0),
+      ftp_data_fd(0)
+  {
+    ink_zero(name);
     reset();
   }
 };