You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by Zhenbing Feng <fe...@apache.org> on 2021/05/26 17:24:28 UTC
Hystrix and Request Plugin's custom page In shenyu-dashboard.
As more plug-ins are added later, it is likely that we will encounter that
the current configuration of the plug-in page cannot meet the demand and
needs to be customized. But on the current situation and research.
I understand that the changes will be more Rule configuration pop-up page
in the middle of the Rule Handler piece.
Suggestions to see if it is feasible to.
1, a, the Rule configuration pop-up page of the middle Rule Handler piece,
a separate component extracted for the CommonRuleHandle.
The original common plug-in use CommonRuleHandle
b, the rule has a personalized needs of the plug-in separate use of
personalized development of xxxRuleHandle.
2, in order to avoid writing if to determine which xxxRuleHandle component
is currently used inside the current common Rule component.
We can give the need to customize the plug-in RuleHandle, in the
pluginhandle page with a FieldType=Plugin field name for ruleHandlePageType
drop-down selection field. (Common/Custom)
[image: image.png]
Example as below:
For legacy issues, the Hystrix plugin uses HystrixRuleHandle alone
Newly developed Request plugin, rule handle also can not be set by the
configuration, there are personalized needs. That is, a separate
RequestRuleHandle is developed.
For the original existing plug-ins for common pages, the default
ruleHandlePageType is common.
For plug-ins that require custom RuleHandle, ruleHandlePageType is Custom,
use [Plugin Name RuleHandle] custom component.
Re: Hystrix and Request Plugin's custom page In shenyu-dashboard.
Posted by XiaoYu <xi...@apache.org>.
this is good job....
Zhenbing Feng <fe...@apache.org> 于2021年6月8日周二 上午12:55写道：
> Hello. I have refactored the page of hystrix and request page in
> https://github.com/dromara/shenyu-dashboard/pull/123.
> If any questions or suggestions, please let me know. Thank you. Regards
>
> Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午11:38写道：
>
> > Ok,I will finish it as soon as possible.
> >
> > XiaoYu <xi...@apache.org> 于2021年5月27日周四 上午10:01写道：
> >
> >> Hi
> >> A good optimization feature indeed， Looking forward to your pull
> request
> >>
> >> thanks！
> >>
> >> Liming Deng <de...@apache.org> 于2021年5月27日周四 上午1:45写道：
> >>
> >> > I think it's a good idea. We will also need a document explaining how
> to
> >> > develop a [Plugin Name RuleHandle] custom component later.
> >> >
> >> > Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午1:24写道：
> >> >
> >> >> As more plug-ins are added later, it is likely that we will encounter
> >> >> that the current configuration of the plug-in page cannot meet the
> >> demand
> >> >> and needs to be customized. But on the current situation and
> research.
> >> >> I understand that the changes will be more Rule configuration pop-up
> >> page
> >> >> in the middle of the Rule Handler piece.
> >> >>
> >> >> Suggestions to see if it is feasible to.
> >> >> 1, a, the Rule configuration pop-up page of the middle Rule Handler
> >> >> piece, a separate component extracted for the CommonRuleHandle.
> >> >> The original common plug-in use CommonRuleHandle
> >> >> b, the rule has a personalized needs of the plug-in separate use
> >> of
> >> >> personalized development of xxxRuleHandle.
> >> >> 2, in order to avoid writing if to determine which xxxRuleHandle
> >> >> component is currently used inside the current common Rule component.
> >> >> We can give the need to customize the plug-in RuleHandle, in the
> >> >> pluginhandle page with a FieldType=Plugin field name for
> >> ruleHandlePageType
> >> >> drop-down selection field. (Common/Custom)
> >> >>
> >> >> [image: image.png]
> >> >> Example as below:
> >> >>
> >> >> For legacy issues, the Hystrix plugin uses HystrixRuleHandle alone
> >> >> Newly developed Request plugin, rule handle also can not be set by
> the
> >> >> configuration, there are personalized needs. That is, a separate
> >> >> RequestRuleHandle is developed.
> >> >>
> >> >> For the original existing plug-ins for common pages, the default
> >> >> ruleHandlePageType is common.
> >> >> For plug-ins that require custom RuleHandle, ruleHandlePageType is
> >> >> Custom, use [Plugin Name RuleHandle] custom component.
> >> >>
> >> >>
> >>
> >
>
Re: Hystrix and Request Plugin's custom page In shenyu-dashboard.
Posted by Zhenbing Feng <fe...@apache.org>.
Hello. I have refactored the page of hystrix and request page in
https://github.com/dromara/shenyu-dashboard/pull/123.
If any questions or suggestions, please let me know. Thank you. Regards
Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午11:38写道：
> Ok,I will finish it as soon as possible.
>
> XiaoYu <xi...@apache.org> 于2021年5月27日周四 上午10:01写道：
>
>> Hi
>> A good optimization feature indeed， Looking forward to your pull request
>>
>> thanks！
>>
>> Liming Deng <de...@apache.org> 于2021年5月27日周四 上午1:45写道：
>>
>> > I think it's a good idea. We will also need a document explaining how to
>> > develop a [Plugin Name RuleHandle] custom component later.
>> >
>> > Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午1:24写道：
>> >
>> >> As more plug-ins are added later, it is likely that we will encounter
>> >> that the current configuration of the plug-in page cannot meet the
>> demand
>> >> and needs to be customized. But on the current situation and research.
>> >> I understand that the changes will be more Rule configuration pop-up
>> page
>> >> in the middle of the Rule Handler piece.
>> >>
>> >> Suggestions to see if it is feasible to.
>> >> 1, a, the Rule configuration pop-up page of the middle Rule Handler
>> >> piece, a separate component extracted for the CommonRuleHandle.
>> >> The original common plug-in use CommonRuleHandle
>> >> b, the rule has a personalized needs of the plug-in separate use
>> of
>> >> personalized development of xxxRuleHandle.
>> >> 2, in order to avoid writing if to determine which xxxRuleHandle
>> >> component is currently used inside the current common Rule component.
>> >> We can give the need to customize the plug-in RuleHandle, in the
>> >> pluginhandle page with a FieldType=Plugin field name for
>> ruleHandlePageType
>> >> drop-down selection field. (Common/Custom)
>> >>
>> >> [image: image.png]
>> >> Example as below:
>> >>
>> >> For legacy issues, the Hystrix plugin uses HystrixRuleHandle alone
>> >> Newly developed Request plugin, rule handle also can not be set by the
>> >> configuration, there are personalized needs. That is, a separate
>> >> RequestRuleHandle is developed.
>> >>
>> >> For the original existing plug-ins for common pages, the default
>> >> ruleHandlePageType is common.
>> >> For plug-ins that require custom RuleHandle, ruleHandlePageType is
>> >> Custom, use [Plugin Name RuleHandle] custom component.
>> >>
>> >>
>>
>
Re: Hystrix and Request Plugin's custom page In shenyu-dashboard.
Posted by Zhenbing Feng <fe...@apache.org>.
Ok,I will finish it as soon as possible.
XiaoYu <xi...@apache.org> 于2021年5月27日周四 上午10:01写道：
> Hi
> A good optimization feature indeed， Looking forward to your pull request
>
> thanks！
>
> Liming Deng <de...@apache.org> 于2021年5月27日周四 上午1:45写道：
>
> > I think it's a good idea. We will also need a document explaining how to
> > develop a [Plugin Name RuleHandle] custom component later.
> >
> > Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午1:24写道：
> >
> >> As more plug-ins are added later, it is likely that we will encounter
> >> that the current configuration of the plug-in page cannot meet the
> demand
> >> and needs to be customized. But on the current situation and research.
> >> I understand that the changes will be more Rule configuration pop-up
> page
> >> in the middle of the Rule Handler piece.
> >>
> >> Suggestions to see if it is feasible to.
> >> 1, a, the Rule configuration pop-up page of the middle Rule Handler
> >> piece, a separate component extracted for the CommonRuleHandle.
> >> The original common plug-in use CommonRuleHandle
> >> b, the rule has a personalized needs of the plug-in separate use of
> >> personalized development of xxxRuleHandle.
> >> 2, in order to avoid writing if to determine which xxxRuleHandle
> >> component is currently used inside the current common Rule component.
> >> We can give the need to customize the plug-in RuleHandle, in the
> >> pluginhandle page with a FieldType=Plugin field name for
> ruleHandlePageType
> >> drop-down selection field. (Common/Custom)
> >>
> >> [image: image.png]
> >> Example as below:
> >>
> >> For legacy issues, the Hystrix plugin uses HystrixRuleHandle alone
> >> Newly developed Request plugin, rule handle also can not be set by the
> >> configuration, there are personalized needs. That is, a separate
> >> RequestRuleHandle is developed.
> >>
> >> For the original existing plug-ins for common pages, the default
> >> ruleHandlePageType is common.
> >> For plug-ins that require custom RuleHandle, ruleHandlePageType is
> >> Custom, use [Plugin Name RuleHandle] custom component.
> >>
> >>
>
Re: Hystrix and Request Plugin's custom page In shenyu-dashboard.
Posted by XiaoYu <xi...@apache.org>.
Hi
A good optimization feature indeed， Looking forward to your pull request
thanks！
Liming Deng <de...@apache.org> 于2021年5月27日周四 上午1:45写道：
> I think it's a good idea. We will also need a document explaining how to
> develop a [Plugin Name RuleHandle] custom component later.
>
> Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午1:24写道：
>
>> As more plug-ins are added later, it is likely that we will encounter
>> that the current configuration of the plug-in page cannot meet the demand
>> and needs to be customized. But on the current situation and research.
>> I understand that the changes will be more Rule configuration pop-up page
>> in the middle of the Rule Handler piece.
>>
>> Suggestions to see if it is feasible to.
>> 1, a, the Rule configuration pop-up page of the middle Rule Handler
>> piece, a separate component extracted for the CommonRuleHandle.
>> The original common plug-in use CommonRuleHandle
>> b, the rule has a personalized needs of the plug-in separate use of
>> personalized development of xxxRuleHandle.
>> 2, in order to avoid writing if to determine which xxxRuleHandle
>> component is currently used inside the current common Rule component.
>> We can give the need to customize the plug-in RuleHandle, in the
>> pluginhandle page with a FieldType=Plugin field name for ruleHandlePageType
>> drop-down selection field. (Common/Custom)
>>
>> [image: image.png]
>> Example as below:
>>
>> For legacy issues, the Hystrix plugin uses HystrixRuleHandle alone
>> Newly developed Request plugin, rule handle also can not be set by the
>> configuration, there are personalized needs. That is, a separate
>> RequestRuleHandle is developed.
>>
>> For the original existing plug-ins for common pages, the default
>> ruleHandlePageType is common.
>> For plug-ins that require custom RuleHandle, ruleHandlePageType is
>> Custom, use [Plugin Name RuleHandle] custom component.
>>
>>
Re: Hystrix and Request Plugin's custom page In shenyu-dashboard.
Posted by Liming Deng <de...@apache.org>.
I think it's a good idea. We will also need a document explaining how to
develop a [Plugin Name RuleHandle] custom component later.
Zhenbing Feng <fe...@apache.org> 于2021年5月27日周四 上午1:24写道：
> As more plug-ins are added later, it is likely that we will encounter that
> the current configuration of the plug-in page cannot meet the demand and
> needs to be customized. But on the current situation and research.
> I understand that the changes will be more Rule configuration pop-up page
> in the middle of the Rule Handler piece.
>
> Suggestions to see if it is feasible to.
> 1, a, the Rule configuration pop-up page of the middle Rule Handler piece,
> a separate component extracted for the CommonRuleHandle.
> The original common plug-in use CommonRuleHandle
> b, the rule has a personalized needs of the plug-in separate use of
> personalized development of xxxRuleHandle.
> 2, in order to avoid writing if to determine which xxxRuleHandle component
> is currently used inside the current common Rule component.
> We can give the need to customize the plug-in RuleHandle, in the
> pluginhandle page with a FieldType=Plugin field name for ruleHandlePageType
> drop-down selection field. (Common/Custom)
>
> [image: image.png]
> Example as below:
>
> For legacy issues, the Hystrix plugin uses HystrixRuleHandle alone
> Newly developed Request plugin, rule handle also can not be set by the
> configuration, there are personalized needs. That is, a separate
> RequestRuleHandle is developed.
>
> For the original existing plug-ins for common pages, the default
> ruleHandlePageType is common.
> For plug-ins that require custom RuleHandle, ruleHandlePageType is Custom,
> use [Plugin Name RuleHandle] custom component.
>
>