You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "arjun4084346 (via GitHub)" <gi...@apache.org> on 2024/08/07 19:07:50 UTC
[PR] add PENDING_RETRY as an execution status in calculating job status in… [gobblin]
arjun4084346 opened a new pull request, #4018:
URL: https://github.com/apache/gobblin/pull/4018
… GaaSObservabilityEvent
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add PENDING_RETRY as an execution status in calculating job status in… [gobblin]
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707876270
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
call to modifyStateIfRetryRequired is pushed later in time (in code diff it is being shown above the older position, but actually that code runs before this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2127] do not emit GaaSObservabilityEvent for a failed job that is going to be retried [gobblin]
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 merged PR #4018:
URL: https://github.com/apache/gobblin/pull/4018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2127] do not emit GaaSObservabilityEvent for a failed job that is going to be retried [gobblin]
Posted by "umustafi (via GitHub)" <gi...@apache.org>.
umustafi commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707915249
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
this bug is hard to follow can u comment why the state check was moved here so it is not changed in the future
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
+
+ if (updatedJobStatus.getRight() == NewState.FINISHED && !retryRequired) {
+ // do not send event if retry is required, because it can alert users to re-submit a job that is already set to be retried by GaaS
Review Comment:
helpful comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2127] do not emit GaaSObservabilityEvent for a failed job that is going to be retried [gobblin]
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707987848
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
added a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add PENDING_RETRY as an execution status in calculating job status in… [gobblin]
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707876270
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
call to modifyStateIfRetryRequired is pushed to later in time (in code diff it is being shown above the older position, but actually that code runs before this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org