You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/25 09:18:36 UTC

[GitHub] [superset] kgabryje commented on pull request #19308: feat(explore): SQL popover in datasource panel

kgabryje commented on pull request #19308:
URL: https://github.com/apache/superset/pull/19308#issuecomment-1078814043


   > Codes LGTM! Thanks for bringing this Popover, and the SQL is more readable!
   > 
   > There are some no-blocking design suggestions:
   > 
   > 1. Could we add a scalable modal so that zoom in and out.
   > 
   > <img alt="image" width="630" src="https://user-images.githubusercontent.com/2016594/160071067-e34c395b-4f27-4ab1-b002-fb0d73b517b8.png">
   > 
   
   Thanks for the review! I like the idea of adding a resizer to the popover. However I'd suggest implementing it as a separate PR as there are a few edge cases to consider 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org