You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by xiayun200825 <gi...@git.apache.org> on 2017/03/02 01:22:29 UTC
[GitHub] incubator-weex pull request #14: return data-undefined when getItem fail
GitHub user xiayun200825 opened a pull request:
https://github.com/apache/incubator-weex/pull/14
return data-undefined when getItem fail
### bugfix
1. WXStorage: return data:undefined when getItem fail
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiayun200825/incubator-weex 0.11-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 4c58864fe1befb450e8f05cdcd8cb883bb27c3ea
Author: xiayun <xi...@163.com>
Date: 2017-03-02T01:18:23Z
return data-undefined when getItem fail
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #14: return data-undefined when getItem fail
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #14: return data-undefined when getItem fail
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/14
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
1 Error
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false">Objective-C file \u2018ios/sdk/WeexSDKTests/WXStorageTests.m\u2019 does not have the copyright header.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Warning">
3 Warnings
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/xiayun200825/incubator-weex/blob/166442ebf0f5e810bd88e5a93d4310f7f58cf6f8/ios/sdk/WeexSDKTests/WXStorageTests.m#L123">ios/sdk/WeexSDKTests/WXStorageTests.m#L123</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/xiayun200825/incubator-weex/blob/166442ebf0f5e810bd88e5a93d4310f7f58cf6f8/ios/sdk/WeexSDKTests/WXStorageTests.m#L227">ios/sdk/WeexSDKTests/WXStorageTests.m#L227</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/xiayun200825/incubator-weex/blob/166442ebf0f5e810bd88e5a93d4310f7f58cf6f8/ios/sdk/WeexSDKTests/WXStorageTests.m#L228">ios/sdk/WeexSDKTests/WXStorageTests.m#L228</a></strong>: unused variable \u2018ts\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval ts = [infoDic[@"key4"][@"ts"] doubleValue];
</code></td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 37.469 (37.585) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---