[GitHub] [spark] attilapiros commented on a change in pull request #24264: [SPARK-27216][CORE] Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24264: [SPARK-27216][CORE] Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue
URL: https://github.com/apache/spark/pull/24264#discussion_r270897790
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/serializer/UnsafeKryoSerializerSuite.scala
 ##########
 @@ -32,4 +34,19 @@ class UnsafeKryoSerializerSuite extends KryoSerializerSuite {
     conf.set(KRYO_USE_UNSAFE, false)
     super.afterAll()
   }
+
+  test("SPARK-27216: Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue") {
 
 Review comment:
   Please move your test into `KryoSerializerSuite` where `conf.set(KRYO_USE_UNSAFE, false)` is given. 
   And as `UnsafeKryoSerializerSuite` is inherited from `KryoSerializerSuite` beside using `conf.set(KRYO_USE_UNSAFE, true)` in `beforeAll()` it will **inherit your test method** so both the safe/unsafe case will be tested by this. 
   
   Summary: you do not need to test both cases in one test method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org