You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/15 11:11:21 UTC
[GitHub] [beam] kamilwu opened a new pull request #12264: Enable spotless for all groovy files
kamilwu opened a new pull request #12264:
URL: https://github.com/apache/beam/pull/12264
Groovy files in .test-infra/jenkins directory are not covered by spotless. As a result, many of them follow different styles and conventions. This PR changes gradle settings so that it will be possible to run _spotlessApply_ and _spotlessCheck_ on .test-infra/jenkins/*.groovy files.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-658709751
R: @iemejia @mwalenia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-664148076
Thanks @kamilwu great to see `./gradlew spotlessCheck` failing eagerly!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662429116
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662427290
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662436758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu merged pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu merged pull request #12264:
URL: https://github.com/apache/beam/pull/12264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-658739456
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662437428
Run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia edited a comment on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
iemejia edited a comment on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-664148076
Thanks @kamilwu great to see `./gradlew spotlessCheck` failing eagerly for .groovy files too!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-661963674
> Is there a spotless autochecker/formatter for gradle files? It would be nice if we could guarantee to have those consistent too given how similar they are to .groovy file
Yes, the commands are: `./gradlew spotlessGroovyGradleCheck` and `./gradlew spotlessGroovyGradleApply`. But the problem is that `build.gradle` files need to include `applyGroovyNature()` line in order to make spotless work. At the moment, not every file includes it. I think I can fix that, even as a part of this PR. Let me do this tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662439957
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-661885198
Arggh it seems there is already a conflict so can you please add the spotlessCheck fail build fix with the rebase. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia edited a comment on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
iemejia edited a comment on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-661885198
Arggh it seems there is already a conflict so you need to rebase, so in that case can you please add the spotlessCheck fail build fix with the rebase. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-658739585
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662427290
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662436505
Thanks @iemejia. I'll merge the PR once all checks pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662436758
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662425519
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-661727731
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662425519
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662435590
> But the problem is that build.gradle files need to include applyGroovyNature() line in order to make spotless work. At the moment, not every file includes it. I think I can fix that
After rethinking this a little bit, I think we need something better. When creating new build.gradle files, people would need to know that they have to include `applyGroovyNature()`. We have to set up a more automatic solution to enforce spotless for those files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-662439957
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12264: Enable spotless for all groovy files
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12264:
URL: https://github.com/apache/beam/pull/12264#issuecomment-661964281
> Can you please refer that the groovy files are also auto formatted in Beam's contribution guide.
What contribution guide are you thinking of? Is it `Developer Guides` in wiki?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org