You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/18 18:20:00 UTC
[GitHub] [tvm] gussmith23 opened a new pull request #8070: BYODT plays nicely with Relay parser
gussmith23 opened a new pull request #8070:
URL: https://github.com/apache/tvm/pull/8070
Previously, there were no Bring Your Own Datatypes parser tests included in the Relay parser tests, so when the Relay parser changed recently, BYODT's parsing broke. This change fixes the parser and adds a test to prevent similar breakage in the future.
- BYODT datatypes now use the format "custom_<typename><bits>x<lanes>" rather than "custom[<typename>]<bits>x<lanes>"
There's a commented-out test that doesn't yet work. I want to get that working. Additionally, I need to search for other places where we need to make this syntax change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843604680
https://docs.github.com/en/github/authenticating-to-github/error-permission-denied-publickey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844345929
> The parameter needs to be renamed in the `params` dictionary as well. Print out the dictionary and you should see the dense_kernel param under the old name.
> […](#)
> On Wed, May 19, 2021, 10:24 AM sahooora ***@***.***> wrote: %dense_kernel:0: can you also delete the :0? The problem here is that there are extra characters showing up in the variable names. If you get errors like these, try just renaming the variables to "normal looking" names. (Relay follows pretty standard rules for naming variables and declaring types, e.g. <variable name>: <type> where the variable name can be [A-Za-z0-9_]). Thanks. I tried dense_kernel and the error has gone. but I got the following error when I wanted to execute the model: result_myfloat = ex.evaluate()(input_st, **params) File "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/build_module.py", line 385, in _graph_wrapper args = self._convert_args(self.mod["main"], args, kwargs) File "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/backend/interpreter.py", line 120, in _convert_args cargs.appen
d(kwargs[name]) KeyError: 'dense_kernel' — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <[#8070 (comment)](https://github.com/apache/tvm/pull/8070#issuecomment-844312017)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJFZANER3NDKDIDH2BTIQ3TOPX5NANCNFSM45DBBYRQ> .
Thanks. It works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843615238
> It sounds like your repository is in a weird state. can you post the output of `git status`? I suspect you need to run `git submodule sync` and `git submodule update` for some of the submodules. if `git status` shows that there are changes in any submodules, run those commands on the submodules.
> […](#)
> On Tue, May 18, 2021, 3:27 PM sahooora ***@***.***> wrote: Do you have an SSH key added to Github? I've added an SSH key to Github and it solves the error. Thanks! Now for "make tvm" I got a bunch of errors. For example, the first error is: tvm/include/tvm/runtime/c_runtime_api.h:135:9: error: ‘DLContext’ does not name a type; did you mean ‘kTVMContext’? typedef DLContext TVMContext; — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <[#8070 (comment)](https://github.com/apache/tvm/pull/8070#issuecomment-843608906)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJFZAK54ZPUHOUJ5SDFFMDTOLST7ANCNFSM45DBBYRQ> .
The output of "git status":
```
On branch 2021-05-18-fix-byodt-parsing
Your branch is up to date with 'gussmith23/2021-05-18-fix-byodt-parsing'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: ../3rdparty/dlpack (new commits)
modified: ../3rdparty/dmlc-core (new commits)
modified: ../3rdparty/vta-hw (new commits)
Untracked files:
(use "git add <file>..." to include in what will be committed)
../3rdparty/libbacktrace/
no changes added to commit (use "git add" and/or "git commit -a")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843572142
> Try adding my fork of TVM as a remote and checking out the branch related to this PR:
>
> ```
> git remote add gussmith23 git@github.com:gussmith23/tvm
> git fetch
> git checkout 2021-05-18-fix-byodt-parsing
> ```
>
> Then rebuild TVM!
Thanks for your instant reply!
I tried but I got the following error:
`error: pathspec '2021-05-18-fix-byodt-parsing' did not match any file(s) known to git.`
I also tried `git fetch --all` but it seems I don't have permission:
```
Fetching origin
Fetching gussmith23
The authenticity of host 'github.com (140.82.121.3)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,140.82.121.3' (RSA) to the list of known hosts.
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
error: Could not fetch gussmith23
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844247693
FWIW these seem like importer bugs. We should make another issue for this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843624693
> git submodule sync dlpack
Thanks!!
I could rebuild tvm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-1008437020
I assume this is no longer active.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843901916
Thanks @gussmith23 .
My error which is related to custom data type has been solved.
Now for the following snippet code, I get an error that is not related to custom data type:
```
r = """
#[version = "0.0.5"]
def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense/kernel:0: Tensor[(128, 6), custom_float_st128], %dense/bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), custom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) {
...
}
"""
module = tvm.parser.fromtext(source = r)
```
Error:
```
error: expected a local variable found `/`
--> from_string:3:75
|
3 | def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense/kernel:0: Tensor[(128, 6), custom_float_st128], %dense/bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), custom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) {
| ^
note: run with `TVM_BACKTRACE=1` environment variable to display a backtrace.
```
Any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843612061
It sounds like your repository is in a weird state. can you post the output
of `git status`?
I suspect you need to run `git submodule sync` and `git submodule update`
for some of the submodules. if `git status` shows that there are changes in
any submodules, run those commands on the submodules.
On Tue, May 18, 2021, 3:27 PM sahooora ***@***.***> wrote:
> Do you have an SSH key added to Github?
>
> I've added an SSH key to Github and it solves the error. Thanks!
> Now for "make tvm" I got a bunch of errors. For example, the first error
> is:
>
> tvm/include/tvm/runtime/c_runtime_api.h:135:9: error: ‘DLContext’ does not name a type; did you mean ‘kTVMContext’?
>
> typedef DLContext TVMContext;
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/8070#issuecomment-843608906>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJFZAK54ZPUHOUJ5SDFFMDTOLST7ANCNFSM45DBBYRQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843589929
Do you have an SSH key added to Github?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843631022
no prob! let me know if the changes fix your issues!
On Tue, May 18, 2021, 4:08 PM sahooora ***@***.***> wrote:
> git submodule sync dlpack
>
> Thanks!!
>
> I could rebuild tvm.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/8070#issuecomment-843624693>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJFZALPN3RYPGKHSGSFXGTTOLXM7ANCNFSM45DBBYRQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843564051
Try adding my fork of TVM as a remote and checking out the branch related to this PR:
```
git remote add gussmith23 git@github.com:gussmith23/tvm
git fetch
git checkout 2021-05-18-fix-byodt-parsing
```
Then rebuild TVM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844352998
Woohoo!!
On Wed, May 19, 2021, 11:08 AM sahooora ***@***.***> wrote:
> The parameter needs to be renamed in the params dictionary as well. Print
> out the dictionary and you should see the dense_kernel param under the old
> name.
> … <#m_-7651436855842596344_>
> On Wed, May 19, 2021, 10:24 AM sahooora *@*.***> wrote: %dense_kernel:0:
> can you also delete the :0? The problem here is that there are extra
> characters showing up in the variable names. If you get errors like these,
> try just renaming the variables to "normal looking" names. (Relay follows
> pretty standard rules for naming variables and declaring types, e.g. :
> where the variable name can be [A-Za-z0-9_]). Thanks. I tried dense_kernel
> and the error has gone. but I got the following error when I wanted to
> execute the model: result_myfloat = ex.evaluate()(input_st, **params) File
> "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/build_module.py",
> line 385, in _graph_wrapper args = self._convert_args(self.mod["main"],
> args, kwargs) File
> "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/backend/interpreter.py",
> line 120, in _convert_args cargs.append(kwargs[name]) KeyError:
> 'dense_kernel' — You are receiving this because you were mentioned. Reply
> to this email directly, view it on GitHub <#8070 (comment)
> <https://github.com/apache/tvm/pull/8070#issuecomment-844312017>>, or
> unsubscribe
> https://github.com/notifications/unsubscribe-auth/AAJFZANER3NDKDIDH2BTIQ3TOPX5NANCNFSM45DBBYRQ
> .
>
> Thanks. It works
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/8070#issuecomment-844345929>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJFZANBLPAVEJNNVEXJ4TTTOP5DNANCNFSM45DBBYRQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843542798
Thanks, @gussmith23.
I can't find any .patch file! Could you please help me with applying the patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
masahi closed pull request #8070:
URL: https://github.com/apache/tvm/pull/8070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-880937886
Hi Gus,
In the latest version of TVM, we can pass params to `create_executor` API:
`ex = tvm.relay.create_executor("graph", module, tvm.cpu(0), target, params)`
Is it possible for you to add this modification to this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843608906
> Do you have an SSH key added to Github?
I've added an SSH key to Github and it solves the error. Thanks!
Now for "make tvm" I got a bunch of errors. For example, the first error is:
```
tvm/include/tvm/runtime/c_runtime_api.h:135:9: error: ‘DLContext’ does not name a type; did you mean ‘kTVMContext’?
typedef DLContext TVMContext;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844157272
I don't think %dense/kernel is a valid variable name. where did that come
from? try replacing the slash with an underscore.
What importer are you using?
On Wed, May 19, 2021, 2:03 AM sahooora ***@***.***> wrote:
> Thanks @gussmith23 <https://github.com/gussmith23> .
> My error which is related to custom data type has been solved.
>
> Now for the following snippet code, I get an error that is not related to
> custom data type:
>
> r = """
> #[version = "0.0.5"]
> def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense/kernel:0: Tensor[(128, 6), custom_float_st128], %dense/bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), custom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) {
> ...
> }
> """
> module = tvm.parser.fromtext(source = r)
>
> Error:
>
> error: expected a local variable found `/`
> --> from_string:3:75
> |
> 3 | def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense/kernel:0: Tensor[(128, 6), custom_float_st128], %dense/bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), custom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) {
> | ^
> note: run with `TVM_BACKTRACE=1` environment variable to display a backtrace.
>
> Any idea?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/8070#issuecomment-843901916>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJFZAN5PMM3URRN4WXOK5DTON5F5ANCNFSM45DBBYRQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844246754
```%dense_kernel:0:```
can you also delete the `:0`?
The problem here is that there are extra characters showing up in the variable names. If you get errors like these, try just renaming the variables to "normal looking" names. (Relay follows pretty standard rules for naming variables and declaring types, e.g. `<variable name>: <type>` where the variable name can be [A-Za-z0-9_]).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844316401
The parameter needs to be renamed in the `params` dictionary as well. Print
out the dictionary and you should see the dense_kernel param under the old
name.
On Wed, May 19, 2021, 10:24 AM sahooora ***@***.***> wrote:
> %dense_kernel:0:
> can you also delete the :0?
>
> The problem here is that there are extra characters showing up in the
> variable names. If you get errors like these, try just renaming the
> variables to "normal looking" names. (Relay follows pretty standard rules
> for naming variables and declaring types, e.g. <variable name>: <type>
> where the variable name can be [A-Za-z0-9_]).
>
> Thanks.
> I tried dense_kernel and the error has gone. but I got the following
> error when I wanted to execute the model:
>
> result_myfloat = ex.evaluate()(input_st, **params)
> File "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/build_module.py", line 385, in _graph_wrapper
> args = self._convert_args(self.mod["main"], args, kwargs)
> File "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/backend/interpreter.py", line 120, in _convert_args
> cargs.append(kwargs[name])
> KeyError: 'dense_kernel'
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/8070#issuecomment-844312017>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJFZANER3NDKDIDH2BTIQ3TOPX5NANCNFSM45DBBYRQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844165770
> I don't think %dense/kernel is a valid variable name. where did that come from? try replacing the slash with an underscore. What importer are you using?
> […](#)
> On Wed, May 19, 2021, 2:03 AM sahooora ***@***.***> wrote: Thanks @gussmith23 <https://github.com/gussmith23> . My error which is related to custom data type has been solved. Now for the following snippet code, I get an error that is not related to custom data type: r = """ #[version = "0.0.5"] def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense/kernel:0: Tensor[(128, 6), custom_float_st128], %dense/bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), custom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) { ... } """ module = tvm.parser.fromtext(source = r) Error: error: expected a local variable found `/` --> from_string:3:75 | 3 | def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense/kernel:0: Tensor[(128, 6), custom_float_st128], %dense/bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), cu
stom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) { | ^ note: run with `TVM_BACKTRACE=1` environment variable to display a backtrace. Any idea? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <[#8070 (comment)](https://github.com/apache/tvm/pull/8070#issuecomment-843901916)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJFZAN5PMM3URRN4WXOK5DTON5F5ANCNFSM45DBBYRQ> .
I've replaced slash with underscore and this time I got the following error:
```
error: failed to parse type found Token(span=Span(SourceName(from_string, 0x31aa140), 3, 3, 83, 84), token_type=Integer, data=0)
--> from_string:3:83
|
3 | def @main (%input_1: Tensor[(100, 128, 3), custom_float_st128], %dense_kernel:0: Tensor[(128, 6), custom_float_st128], %dense_bias:0: Tensor[(6), custom_float_st128], %lstm_W: Tensor[(1, 512, 3), custom_float_st128], %lstm_R: Tensor[(1, 512, 128), custom_float_st128], %lstm_B: Tensor[(1, 1024), custom_float_st128]) {
| ^
note: run with `TVM_BACKTRACE=1` environment variable to display a backtrace.
```
I also tried with another model with a variable name such as: %project_inp.bias and I got the same error:
```
error: expected a local variable found `.`
...
```
I'm using `relay.frontend.from_onnx` for importing my onnx model.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gussmith23 commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-843617261
please do `git submodule sync dlpack` and `git submodule update dlpack`. do this with `dmlc-core` and `vta-hw` as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sahooora commented on pull request #8070: BYODT plays nicely with Relay parser
Posted by GitBox <gi...@apache.org>.
sahooora commented on pull request #8070:
URL: https://github.com/apache/tvm/pull/8070#issuecomment-844312017
> `%dense_kernel:0:`
> can you also delete the `:0`?
>
> The problem here is that there are extra characters showing up in the variable names. If you get errors like these, try just renaming the variables to "normal looking" names. (Relay follows pretty standard rules for naming variables and declaring types, e.g. `<variable name>: <type>` where the variable name can be [A-Za-z0-9_]).
Thanks.
I tried `dense_kernel` and the error has gone. but I got the following error when I wanted to execute the model:
```
result_myfloat = ex.evaluate()(input_st, **params)
File "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/build_module.py", line 385, in _graph_wrapper
args = self._convert_args(self.mod["main"], args, kwargs)
File "/home/sara/.local/lib/python3.6/site-packages/tvm-0.8.dev591+g4dfa7dfb4-py3.6-linux-x86_64.egg/tvm/relay/backend/interpreter.py", line 120, in _convert_args
cargs.append(kwargs[name])
KeyError: 'dense_kernel'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org