[GitHub] [airflow] potiuk edited a comment on issue #8169: [AIRFLOW-XXXX] Minor improvement in Dockerfile

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #8169: [AIRFLOW-XXXX] Minor improvement in Dockerfile
URL: https://github.com/apache/airflow/pull/8169#issuecomment-610258682
 
 
   I think that change might be actually more misleading.
   
   The image is prepared in the way that it can be installed from different sources "." - local sources, PyPi, GitHub URL. Therfor AIRFLOW_SOURCES_FROM and AIRFLOW_INSTALL_SOURCES might have different forms - it can be "." (for local sources) but it also can be "apache-airflow" for installing from PyPI as well as "https://github.com/apache/airflow/archive/1.10.10.tar.gz#egg=apache-airflow"
   
   Take for example:
   ```
   CONSTRAINT_REQUIREMENTS=" "${AIRFLOW_SOURCES_FROM}/requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt"
   ```
   This might suggest that it will work correctly when we just replace AIRFLOW_SOURCES_FROM with "apache-airflow" - which is not OK (you need to override COSTRAINT_REQUIREMENTS to point to URL in this case. For example:
   
   ```
     --build-arg CONSTRAINT_REQUIREMENTS="https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt"
   ```
   
   Those args should be set independently and there are different sets of those args that are valid - and there is no relation between them that is suggested by this change.
   
   See examples here: 
   https://github.com/apache/airflow/blob/master/IMAGES.rst#production-images 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services