You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2023/03/03 06:01:36 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request, #29891: Classic TaskGroup setup/teardown
ephraimbuddy opened a new pull request, #29891:
URL: https://github.com/apache/airflow/pull/29891
This implements the classic TaskGroup setup/teardown. Ensures that nested TaskGroups are taken into account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #29891: Classic TaskGroup setup/teardown
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #29891:
URL: https://github.com/apache/airflow/pull/29891#discussion_r1133582049
##########
airflow/utils/task_group.py:
##########
@@ -92,11 +92,15 @@ def __init__(
ui_color: str = "CornflowerBlue",
ui_fgcolor: str = "#000",
add_suffix_on_collision: bool = False,
+ setup: bool = False,
+ teardown: bool = False,
):
from airflow.models.dag import DagContext
self.prefix_group_id = prefix_group_id
self.default_args = copy.deepcopy(default_args or {})
+ self.setup = setup
+ self.teardown = teardown
Review Comment:
Should these be mutually exclusive, or can a task group be both setup and teardown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29891: Classic TaskGroup setup/teardown
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #29891:
URL: https://github.com/apache/airflow/pull/29891#discussion_r1133754689
##########
airflow/utils/task_group.py:
##########
@@ -92,11 +92,15 @@ def __init__(
ui_color: str = "CornflowerBlue",
ui_fgcolor: str = "#000",
add_suffix_on_collision: bool = False,
+ setup: bool = False,
+ teardown: bool = False,
):
from airflow.models.dag import DagContext
self.prefix_group_id = prefix_group_id
self.default_args = copy.deepcopy(default_args or {})
+ self.setup = setup
+ self.teardown = teardown
Review Comment:
Should be mutually exclusive. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #29891: Classic TaskGroup setup/teardown
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #29891:
URL: https://github.com/apache/airflow/pull/29891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org