You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Bill Cole <sa...@billmail.scconsult.com> on 2018/08/22 03:12:02 UTC
Re: svn commit: r1838588 - /spamassassin/branches/3.4/t/dnsbl.t
On 21 Aug 2018, at 19:22 (-0400), kmcgrail@apache.org wrote:
> Author: kmcgrail
> Date: Tue Aug 21 23:22:01 2018
> New Revision: 1838588
>
> URL: http://svn.apache.org/viewvc?rev=1838588&view=rev
> Log:
> Reminder not to leave -D
>
> Modified:
> spamassassin/branches/3.4/t/dnsbl.t
>
> Modified: spamassassin/branches/3.4/t/dnsbl.t
> URL:
> http://svn.apache.org/viewvc/spamassassin/branches/3.4/t/dnsbl.t?rev=1838588&r1=1838587&r2=1838588&view=diff
> ==============================================================================
> --- spamassassin/branches/3.4/t/dnsbl.t (original)
> +++ spamassassin/branches/3.4/t/dnsbl.t Tue Aug 21 23:22:01 2018
> @@ -160,5 +160,6 @@ describe DNSBL_SB_MISS DNSBL SenderBase
> tflags DNSBL_SB_MISS net
> ");
>
> -sarun ("-D -t < data/spam/dnsbl.eml 2>&1", \&patterns_run_cb);
> +#note: don't leave -D here, it causes spurious passes
> +sarun ("-t < data/spam/dnsbl.eml 2>&1", \&patterns_run_cb);
> ok_all_patterns();
This change is bad. It causes the test to fail spuriously and it shuts
off the possibility of one of the antipatterns ever matching, since the
match is against a debug message.
My earlier small change to the patterns in this test relied on the -D
output, as does the core of one of the antipatterns. The former could be
fixed, the latter not so much. This change and its "reminder" antecedent
should be reversed.
--
Bill Cole
bill@scconsult.com or billcole@apache.org
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Currently Seeking Steadier Work: https://linkedin.com/in/billcole
Re: svn commit: r1838588 - /spamassassin/branches/3.4/t/dnsbl.t
Posted by "Kevin A. McGrail" <km...@apache.org>.
On 8/21/2018 11:12 PM, Bill Cole wrote:
> This change is bad. It causes the test to fail spuriously and it shuts
> off the possibility of one of the antipatterns ever matching, since
> the match is against a debug message.
>
> My earlier small change to the patterns in this test relied on the -D
> output, as does the core of one of the antipatterns. The former could
> be fixed, the latter not so much. This change and its "reminder"
> antecedent should be reversed.
>
Also added to the note.
Re: svn commit: r1838588 - /spamassassin/branches/3.4/t/dnsbl.t
Posted by "Kevin A. McGrail" <km...@apache.org>.
On 8/21/2018 11:12 PM, Bill Cole wrote:
> This change is bad. It causes the test to fail spuriously and it shuts
> off the possibility of one of the antipatterns ever matching, since
> the match is against a debug message.
>
> My earlier small change to the patterns in this test relied on the -D
> output, as does the core of one of the antipatterns. The former could
> be fixed, the latter not so much. This change and its "reminder"
> antecedent should be reversed.
>
Also added to the note.