[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

[GitBox <gi...@apache.org>]

mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855685351


##########
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##########
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
     boolean sanityCheck = Arrays.asList(args).contains("--sanity-check");
 
     if (sanityCheck && GraphicsEnvironment.isHeadless()) {
-      Logger.getGlobal().log(Level.SEVERE, "[Vader] Hello, Luke. Can't do much in headless mode.");
-      Runtime.getRuntime().exit(0);
+      Logger.getGlobal().log(Level.SEVERE, "Hello, Luke. Can't do much in headless mode.");
+      Runtime.getRuntime().exit(1);

Review Comment:
   I think it may be better to keep the test run on the headless mode; I'm afraid that setting up a virtual window environment on every CI server (every OS) can increase the administrator's load...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org