You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/08/20 00:43:26 UTC

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18875


Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................

IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Machines that don't have en_US.UTF-8 installed see
issues when running ExprTest.Utf8MaskTest.
This currently impacts the Docker-based tests.
This installs the appropriate language packs
to have en_US.UTF-8 installed.

Testing:
 - Ran docker-based tests and verified that
   ExprTest.Utf8MaskTest passes.

Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18875/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1:

Not related, retrying


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Aug 2022 21:56:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8478/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Aug 2022 04:55:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8479/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Aug 2022 21:56:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Aug 2022 02:50:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11196/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Aug 2022 01:04:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................

IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Machines that don't have en_US.UTF-8 installed see
issues when running ExprTest.Utf8MaskTest.
This currently impacts the Docker-based tests.
This installs the appropriate language packs
to have en_US.UTF-8 installed.

Testing:
 - Ran docker-based tests and verified that
   ExprTest.Utf8MaskTest passes.

Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Reviewed-on: http://gerrit.cloudera.org:8080/18875
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Quanlong Huang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8478/


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Aug 2022 09:41:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18875 )

Change subject: IMPALA-11492: Add langpacks-en (centos) and language-pack-en (Ubuntu)
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8696190e4713bda787e773d48943b5dfc6335e
Gerrit-Change-Number: 18875
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 21 Aug 2022 04:49:03 +0000
Gerrit-HasComments: No