You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/23 20:37:15 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
pkarashchenko opened a new pull request, #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401
## Summary
This PR contain few fixes for stm32h7 flash interface:
- Fix cache invalidation before reading flash data after flash erase operation
- Fix `stm32h7_israngeerased` operation to use the correct address
- Fix error checking in `stm32h7_israngeerased`
- Replace exclusive semaphore with mutex
- Fix few style issues
## Impact
Bug fix
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1290190758
> > @tito97sp should we merge this patch instead yours(#7397)?
>
> @xiaoxiang781216 Yes. This PR substitutes mine.
Could you please approve the PR if all the tests pass at your end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
tito97sp commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1290140269
> @tito97sp should we merge this patch instead yours(#7397)?
Yes. This PR substitutes mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
tito97sp commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1290224461
> > > > @tito97sp should we merge this patch instead yours(#7397)?
> > >
> > >
> > > @xiaoxiang781216 Yes. This PR substitutes mine.
> >
> >
> > Could you please approve the PR if all the tests pass at your end?
>
> I'm on it
Hi @pkarashchenko how can I move to your PR on local??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
davids5 merged PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1290015336
@tito97sp should we merge this patch instead yours(#7397)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
tito97sp commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1290219433
> > > @tito97sp should we merge this patch instead yours(#7397)?
> >
> >
> > @xiaoxiang781216 Yes. This PR substitutes mine.
>
> Could you please approve the PR if all the tests pass at your end?
I'm on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
tito97sp commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1290261126
Test passed on local. Ready to merge @pkarashchenko @xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7401:
URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1288336647
please rebase the change to fix the ci error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org