You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/28 04:34:23 UTC

[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18182: Fixed Install page history broken

ys2843 opened a new pull request #18182:
URL: https://github.com/apache/incubator-mxnet/pull/18182


   ## Description ##
   Fixed issue https://github.com/apache/incubator-mxnet/issues/14583. On [get started page](https://mxnet.apache.org/get_started) when navigating back in session history through browser `back` button, the "Installing MXNet" options block does not update while the url was cut shorter. 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   
   ### Changes ###
   - [ ] Update install options section when navigating back history
   - [ ] Avoid install options section buttons' default css style, the blue `outline`, when losing focus during selection update
   
   ## Comments ##
   Preview: pending
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #18182: Fixed Install page history broken

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #18182:
URL: https://github.com/apache/incubator-mxnet/pull/18182#issuecomment-620780207


   Thanks @ys2843 for your contributions! Welcome to MXNet community :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18182: Fixed Install page history broken

Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18182:
URL: https://github.com/apache/incubator-mxnet/pull/18182#issuecomment-620681213






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18182: Fixed Install page history broken

Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18182:
URL: https://github.com/apache/incubator-mxnet/pull/18182#issuecomment-620863687


   All test cases passed, it should be all good to merge. Thanks @zachgk


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18182: Fixed Install page history broken

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on pull request #18182:
URL: https://github.com/apache/incubator-mxnet/pull/18182#issuecomment-620857935


   Congratulations on your first PR @ys2843! Excellent work :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18182: Fixed Install page history broken

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18182:
URL: https://github.com/apache/incubator-mxnet/pull/18182#issuecomment-620374949


   Hey @ys2843 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, centos-cpu, unix-gpu, sanity, windows-gpu, centos-gpu, windows-cpu, website, unix-cpu, clang, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org